2021-08-07 10:25:14

by Saurav Girepunje

Subject: [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable

Remove unused variable data and data_len from mon_recv_decrypted() in mon.c

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
index 73b9599fe0dc..7c7cb29ee005 100644
--- a/drivers/staging/rtl8188eu/os_dep/mon.c
+++ b/drivers/staging/rtl8188eu/os_dep/mon.c
@@ -58,8 +58,7 @@ static void mon_recv_decrypted(struct net_device *dev, const u8 *data,
netif_rx(skb);
}

-static void mon_recv_encrypted(struct net_device *dev, const u8 *data,
- int data_len)
+static void mon_recv_encrypted(struct net_device *dev)
{
if (net_ratelimit())
netdev_info(dev, "Encrypted packets are not supported");
@@ -93,7 +92,7 @@ void rtl88eu_mon_recv_hook(struct net_device *dev, struct recv_frame *frame)
if (attr->bdecrypted)
mon_recv_decrypted(dev, data, data_len, iv_len, icv_len);
else
- mon_recv_encrypted(dev, data, data_len);
+ mon_recv_encrypted(dev);
}

/**
--
2.30.2

2021-08-07 14:51:46

by Fabio Aiuto

Subject: Re: [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable

Hello Saurav,

On Sat, Aug 07, 2021 at 03:52:29PM +0530, Saurav Girepunje wrote:
> Remove unused variable data and data_len from mon_recv_decrypted() in mon.c
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c

did you rebase you local tree on current staging-testing?
rtl8188eu has been deleted... now there's r8188eu.

thank you,

fabio

2021-08-07 19:01:17

by Saurav Girepunje

Subject: Re: [PATCH 1/4] staging: rtl8188eu: os_dep: Remove unused variable

On 07 Aug 2021 16:50, Fabio Aiuto wrote:
> Hello Saurav,
>
> On Sat, Aug 07, 2021 at 03:52:29PM +0530, Saurav Girepunje wrote:
> > Remove unused variable data and data_len from mon_recv_decrypted() in mon.c
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
> > ---
> > drivers/staging/rtl8188eu/os_dep/mon.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/os_dep/mon.c b/drivers/staging/rtl8188eu/os_dep/mon.c
>
> did you rebase you local tree on current staging-testing?
> rtl8188eu has been deleted... now there's r8188eu.
>
> thank you,
>
> fabio

I had not done. Now I did it.

thanks fabio for pointing this.

saurav