2021-08-27 09:30:50

by Kavyasree Kotagiri

[permalink] [raw]
Subject: [PATCH] ARM: at91: add basic support for new SoC lan966x

From: Kavyasree Kotagiri <[email protected]>

This patch introduces Microchip LAN966X ARMv7 based SoC family
of multiport gigabit AVB/TSN-capable ethernet switches.
It supports two SKUs: 4-port LAN9662 with multiprotocol
processing support and 8-port LAN9668 switch.

LAN966X includes copper and serial ethernet interfaces,
peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
SD/eMMC, Parallel Interface (PI) as well as synchronization
and trigger inputs/outputs.

Signed-off-by: Kavya Sree Kotagiri <[email protected]>
---
arch/arm/mach-at91/Kconfig | 13 +++++++++++++
arch/arm/mach-at91/Makefile | 1 +
arch/arm/mach-at91/lan966x.c | 31 +++++++++++++++++++++++++++++++
3 files changed, 45 insertions(+)
create mode 100644 arch/arm/mach-at91/lan966x.c

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index ccd7e80ce943..06cb425af761 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -122,6 +122,14 @@ config SOC_SAM9X60
help
Select this if you are using Microchip's SAM9X60 SoC

+config SOC_LAN966X
+ bool "ARMv7 based Microchip LAN966X SoC family"
+ depends on ARCH_MULTI_V7
+ select SOC_LAN966
+ select DW_APB_TIMER_OF
+ help
+ This enables support for ARMv7 based Microchip LAN966X SoC family.
+
comment "Clocksource driver selection"

config ATMEL_CLOCKSOURCE_PIT
@@ -188,6 +196,11 @@ config SOC_SAMA5
select SOC_SAM_V7
select SRAM if PM

+config SOC_LAN966
+ bool
+ select ARM_GIC
+ select MEMORY
+
config ATMEL_PM
bool

diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
index f565490f1b70..93cfd5b4e6d4 100644
--- a/arch/arm/mach-at91/Makefile
+++ b/arch/arm/mach-at91/Makefile
@@ -6,6 +6,7 @@
# CPU-specific support
obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
obj-$(CONFIG_SOC_AT91SAM9) += at91sam9.o
+obj-$(CONFIG_SOC_LAN966X) += lan966x.o
obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
obj-$(CONFIG_SOC_SAMA5) += sama5.o
obj-$(CONFIG_SOC_SAMV7) += samv7.o
diff --git a/arch/arm/mach-at91/lan966x.c b/arch/arm/mach-at91/lan966x.c
new file mode 100644
index 000000000000..de689f854068
--- /dev/null
+++ b/arch/arm/mach-at91/lan966x.c
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Setup code for LAN966X
+ *
+ * Copyright (C) 2021 Microchip Technology, Inc. and its subsidiaries
+ *
+ */
+
+#include <linux/of.h>
+#include <linux/of_platform.h>
+
+#include <asm/mach/arch.h>
+#include <asm/system_misc.h>
+
+#include "generic.h"
+
+static void __init lan966x_dt_device_init(void)
+{
+ of_platform_default_populate(NULL, NULL, NULL);
+}
+
+static const char *const lan966x_dt_board_compat[] __initconst = {
+ "microchip,lan966x",
+ NULL
+};
+
+DT_MACHINE_START(lan966x_dt, "Microchip LAN966X")
+ /* Maintainer: Microchip */
+ .init_machine = lan966x_dt_device_init,
+ .dt_compat = lan966x_dt_board_compat,
+MACHINE_END
--
2.17.1


2021-08-27 20:20:00

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] ARM: at91: add basic support for new SoC lan966x

Hello Kavya,

Thank you for the patch and the upstreaming effort!

On 27/08/2021 14:56:23+0530, [email protected] wrote:
> From: Kavyasree Kotagiri <[email protected]>
>
> This patch introduces Microchip LAN966X ARMv7 based SoC family
> of multiport gigabit AVB/TSN-capable ethernet switches.
> It supports two SKUs: 4-port LAN9662 with multiprotocol
> processing support and 8-port LAN9668 switch.
>
> LAN966X includes copper and serial ethernet interfaces,
> peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
> SD/eMMC, Parallel Interface (PI) as well as synchronization
> and trigger inputs/outputs.
>
> Signed-off-by: Kavya Sree Kotagiri <[email protected]>
> ---
> arch/arm/mach-at91/Kconfig | 13 +++++++++++++
> arch/arm/mach-at91/Makefile | 1 +
> arch/arm/mach-at91/lan966x.c | 31 +++++++++++++++++++++++++++++++
> 3 files changed, 45 insertions(+)
> create mode 100644 arch/arm/mach-at91/lan966x.c
>
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index ccd7e80ce943..06cb425af761 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -122,6 +122,14 @@ config SOC_SAM9X60
> help
> Select this if you are using Microchip's SAM9X60 SoC
>
> +config SOC_LAN966X
> + bool "ARMv7 based Microchip LAN966X SoC family"
> + depends on ARCH_MULTI_V7
> + select SOC_LAN966
> + select DW_APB_TIMER_OF
> + help
> + This enables support for ARMv7 based Microchip LAN966X SoC family.
> +
> comment "Clocksource driver selection"
>
> config ATMEL_CLOCKSOURCE_PIT
> @@ -188,6 +196,11 @@ config SOC_SAMA5
> select SOC_SAM_V7
> select SRAM if PM
>
> +config SOC_LAN966
> + bool
> + select ARM_GIC
> + select MEMORY
> +
> config ATMEL_PM
> bool
>
> diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> index f565490f1b70..93cfd5b4e6d4 100644
> --- a/arch/arm/mach-at91/Makefile
> +++ b/arch/arm/mach-at91/Makefile
> @@ -6,6 +6,7 @@
> # CPU-specific support
> obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
> obj-$(CONFIG_SOC_AT91SAM9) += at91sam9.o
> +obj-$(CONFIG_SOC_LAN966X) += lan966x.o
> obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
> obj-$(CONFIG_SOC_SAMA5) += sama5.o
> obj-$(CONFIG_SOC_SAMV7) += samv7.o
> diff --git a/arch/arm/mach-at91/lan966x.c b/arch/arm/mach-at91/lan966x.c
> new file mode 100644
> index 000000000000..de689f854068
> --- /dev/null
> +++ b/arch/arm/mach-at91/lan966x.c
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Setup code for LAN966X
> + *
> + * Copyright (C) 2021 Microchip Technology, Inc. and its subsidiaries
> + *
> + */
> +
> +#include <linux/of.h>
> +#include <linux/of_platform.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/system_misc.h>
> +
> +#include "generic.h"
> +
> +static void __init lan966x_dt_device_init(void)
> +{
> + of_platform_default_populate(NULL, NULL, NULL);

Are you sure this is needed? This is a workaround that is there on the
other platforms because of the at91 pinctrl driver. Ideally, you should
be able to boot without that. Can you confirm?

> +}
> +
> +static const char *const lan966x_dt_board_compat[] __initconst = {
> + "microchip,lan966x",
> + NULL
> +};
> +
> +DT_MACHINE_START(lan966x_dt, "Microchip LAN966X")
> + /* Maintainer: Microchip */
> + .init_machine = lan966x_dt_device_init,
> + .dt_compat = lan966x_dt_board_compat,
> +MACHINE_END
> --
> 2.17.1
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com