2021-08-28 13:08:32

by Saurav Girepunje

Subject: [PATCH] staging: r8188eu: os_dep: remove unused static variable

Remove unused static variable rtw_enusbss from os_intfs.c file.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/r8188eu/os_dep/os_intfs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
index 8d0158f4a45d..c3ac0ae153f8 100644
--- a/drivers/staging/r8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
@@ -85,7 +85,6 @@ static int rtw_AcceptAddbaReq = true;/* 0:Reject AP's Add BA req, 1:Accept AP's
static int rtw_antdiv_cfg = 2; /* 0:OFF , 1:ON, 2:decide by Efuse config */
static int rtw_antdiv_type; /* 0:decide by efuse 1: for 88EE, 1Tx and 1RxCG are diversity.(2 Ant with SPDT), 2: for 88EE, 1Tx and 2Rx are diversity.(2 Ant, Tx and RxCG are both on aux port, RxCS is on main port), 3: for 88EE, 1Tx and 1RxCG are fixed.(1Ant, Tx and RxCG are both on aux port) */

-static int rtw_enusbss;/* 0:disable, 1:enable */

static int rtw_hwpdn_mode = 2;/* 0:disable, 1:enable, 2: by EFUSE config */

@@ -133,7 +132,6 @@ module_param(rtw_low_power, int, 0644);
module_param(rtw_wifi_spec, int, 0644);
module_param(rtw_antdiv_cfg, int, 0644);
module_param(rtw_antdiv_type, int, 0644);
-module_param(rtw_enusbss, int, 0644);
module_param(rtw_hwpdn_mode, int, 0644);
module_param(rtw_hwpwrp_detect, int, 0644);
module_param(rtw_hw_wps_pbc, int, 0644);
--
2.32.0

2021-08-28 13:56:05

by Martin Kaiser

Subject: Re: [PATCH] staging: r8188eu: os_dep: remove unused static variable

Thus wrote Saurav Girepunje ([email protected]):

> Remove unused static variable rtw_enusbss from os_intfs.c file.

> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/r8188eu/os_dep/os_intfs.c | 2 --
> 1 file changed, 2 deletions(-)

> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
> index 8d0158f4a45d..c3ac0ae153f8 100644
> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
> @@ -85,7 +85,6 @@ static int rtw_AcceptAddbaReq = true;/* 0:Reject AP's Add BA req, 1:Accept AP's
> static int rtw_antdiv_cfg = 2; /* 0:OFF , 1:ON, 2:decide by Efuse config */
> static int rtw_antdiv_type; /* 0:decide by efuse 1: for 88EE, 1Tx and 1RxCG are diversity.(2 Ant with SPDT), 2: for 88EE, 1Tx and 2Rx are diversity.(2 Ant, Tx and RxCG are both on aux port, RxCS is on main port), 3: for 88EE, 1Tx and 1RxCG are fixed.(1Ant, Tx and RxCG are both on aux port) */

> -static int rtw_enusbss;/* 0:disable, 1:enable */

> static int rtw_hwpdn_mode = 2;/* 0:disable, 1:enable, 2: by EFUSE config */

> @@ -133,7 +132,6 @@ module_param(rtw_low_power, int, 0644);
> module_param(rtw_wifi_spec, int, 0644);
> module_param(rtw_antdiv_cfg, int, 0644);
> module_param(rtw_antdiv_type, int, 0644);
> -module_param(rtw_enusbss, int, 0644);
> module_param(rtw_hwpdn_mode, int, 0644);
> module_param(rtw_hwpwrp_detect, int, 0644);
> module_param(rtw_hw_wps_pbc, int, 0644);
> --
> 2.32.0

Looks ok to me, thanks.

Acked-by: Martin Kaiser <[email protected]>