2021-08-23 14:33:59

by Hector Martin

[permalink] [raw]
Subject: [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()

This automatically selects between ioremap() and ioremap_np() on
platforms that require it, such as Apple SoCs.

Signed-off-by: Hector Martin <[email protected]>
---
drivers/mfd/syscon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index 765c0210cb52..191fdb87c424 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -60,7 +60,7 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
goto err_map;
}

- base = ioremap(res.start, resource_size(&res));
+ base = of_iomap(np, 0);
if (!base) {
ret = -ENOMEM;
goto err_map;
--
2.32.0


2021-08-23 18:34:06

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()

On Mon, Aug 23, 2021 at 4:32 PM Hector Martin <[email protected]> wrote:
>
> This automatically selects between ioremap() and ioremap_np() on
> platforms that require it, such as Apple SoCs.
>
> Signed-off-by: Hector Martin <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>

Lee, please apply for 5.15 if it's not too late.

2021-09-06 11:18:08

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd/syscon: Use of_iomap() instead of ioremap()

On Mon, 23 Aug 2021, Hector Martin wrote:

> This automatically selects between ioremap() and ioremap_np() on
> platforms that require it, such as Apple SoCs.
>
> Signed-off-by: Hector Martin <[email protected]>
> ---
> drivers/mfd/syscon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog