2021-09-22 23:49:21

by Kieran Bingham

Subject: [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0

From: Kieran Bingham <[email protected]>

Extend the Renesas DU display bindings to support the r8a779a0 V3U.

Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Kieran Bingham <[email protected]>

---
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock

v3:
- Use clocknames: 'du.0' instead of 'du' to remain consistent

.../bindings/display/renesas,du.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
index e3ca5389c17d..6db6a3f15395 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.yaml
+++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
@@ -39,6 +39,7 @@ properties:
- renesas,du-r8a77980 # for R-Car V3H compatible DU
- renesas,du-r8a77990 # for R-Car E3 compatible DU
- renesas,du-r8a77995 # for R-Car D3 compatible DU
+ - renesas,du-r8a779a0 # for R-Car V3U compatible DU

reg:
maxItems: 1
@@ -773,6 +774,55 @@ allOf:
- reset-names
- renesas,vsps

+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,du-r8a779a0
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Functional clock
+
+ clock-names:
+ maxItems: 1
+ items:
+ - const: du.0
+
+ interrupts:
+ maxItems: 2
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: du.0
+
+ ports:
+ properties:
+ port@0:
+ description: DSI 0
+ port@1:
+ description: DSI 1
+ port@2: false
+ port@3: false
+
+ required:
+ - port@0
+ - port@1
+
+ renesas,vsps:
+ minItems: 2
+
+ required:
+ - interrupts
+ - resets
+ - reset-names
+ - renesas,vsps
+
additionalProperties: false

examples:
--
2.30.2

2021-09-23 07:45:55

by Geert Uytterhoeven

Subject: Re: [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0

Hi Kieran,

On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham
<[email protected]> wrote:
> From: Kieran Bingham <[email protected]>
>
> Extend the Renesas DU display bindings to support the r8a779a0 V3U.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Kieran Bingham <[email protected]>
>
> ---
> v2:
> - Collected Laurent's tag
> - Remove clock-names requirement
> - Specify only a single clock
>
> v3:
> - Use clocknames: 'du.0' instead of 'du' to remain consistent

Thanks for the update!

> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> @@ -39,6 +39,7 @@ properties:
> - renesas,du-r8a77980 # for R-Car V3H compatible DU
> - renesas,du-r8a77990 # for R-Car E3 compatible DU
> - renesas,du-r8a77995 # for R-Car D3 compatible DU
> + - renesas,du-r8a779a0 # for R-Car V3U compatible DU
>
> reg:
> maxItems: 1
> @@ -773,6 +774,55 @@ allOf:
> - reset-names
> - renesas,vsps
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,du-r8a779a0
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Functional clock
> +
> + clock-names:
> + maxItems: 1
> + items:
> + - const: du.0
> +
> + interrupts:
> + maxItems: 2
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: du.0
> +
> + ports:
> + properties:
> + port@0:
> + description: DSI 0
> + port@1:
> + description: DSI 1
> + port@2: false
> + port@3: false
> +
> + required:
> + - port@0
> + - port@1
> +
> + renesas,vsps:
> + minItems: 2
> +
> + required:
> + - interrupts
> + - resets
> + - reset-names
> + - renesas,vsps

clock-names, for consistency?

> +
> additionalProperties: false
>
> examples:

With the above fixed:
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-09-23 13:05:36

by Kieran Bingham

Subject: [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0

From: Kieran Bingham <[email protected]>

Extend the Renesas DU display bindings to support the r8a779a0 V3U.

Reviewed-by: Laurent Pinchart <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Kieran Bingham <[email protected]>

---
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock

v3:
- Use clocknames: 'du.0' instead of 'du' to remain consistent

v3.1:
- Require clock-names
- Collect Geert's tag

.../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
index e3ca5389c17d..13efea574584 100644
--- a/Documentation/devicetree/bindings/display/renesas,du.yaml
+++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
@@ -39,6 +39,7 @@ properties:
- renesas,du-r8a77980 # for R-Car V3H compatible DU
- renesas,du-r8a77990 # for R-Car E3 compatible DU
- renesas,du-r8a77995 # for R-Car D3 compatible DU
+ - renesas,du-r8a779a0 # for R-Car V3U compatible DU

reg:
maxItems: 1
@@ -773,6 +774,56 @@ allOf:
- reset-names
- renesas,vsps

+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,du-r8a779a0
+ then:
+ properties:
+ clocks:
+ items:
+ - description: Functional clock
+
+ clock-names:
+ maxItems: 1
+ items:
+ - const: du.0
+
+ interrupts:
+ maxItems: 2
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ items:
+ - const: du.0
+
+ ports:
+ properties:
+ port@0:
+ description: DSI 0
+ port@1:
+ description: DSI 1
+ port@2: false
+ port@3: false
+
+ required:
+ - port@0
+ - port@1
+
+ renesas,vsps:
+ minItems: 2
+
+ required:
+ - clock-names
+ - interrupts
+ - resets
+ - reset-names
+ - renesas,vsps
+
additionalProperties: false

examples:
--
2.30.2

2021-09-27 21:01:22

by Rob Herring (Arm)

Subject: Re: [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0

On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote:
> From: Kieran Bingham <[email protected]>
>
> Extend the Renesas DU display bindings to support the r8a779a0 V3U.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Kieran Bingham <[email protected]>
>
> ---
> v2:
> - Collected Laurent's tag
> - Remove clock-names requirement
> - Specify only a single clock
>
> v3:
> - Use clocknames: 'du.0' instead of 'du' to remain consistent
>
> v3.1:
> - Require clock-names
> - Collect Geert's tag
>
> .../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2021-09-28 01:15:32

by Laurent Pinchart

Subject: Re: [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0

On Mon, Sep 27, 2021 at 03:57:34PM -0500, Rob Herring wrote:
> On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote:
> > From: Kieran Bingham <[email protected]>
> >
> > Extend the Renesas DU display bindings to support the r8a779a0 V3U.
> >
> > Reviewed-by: Laurent Pinchart <[email protected]>
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > Signed-off-by: Kieran Bingham <[email protected]>
> >
> > ---
> > v2:
> > - Collected Laurent's tag
> > - Remove clock-names requirement
> > - Specify only a single clock
> >
> > v3:
> > - Use clocknames: 'du.0' instead of 'du' to remain consistent
> >
> > v3.1:
> > - Require clock-names
> > - Collect Geert's tag
> >
> > .../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> Reviewed-by: Rob Herring <[email protected]>

Thank you Rob, that was the missing piece for a pull request :-)

--
Regards,

Laurent Pinchart