2021-09-29 23:30:44

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tags need some work in the iommu tree

---

Hi all,

In commits

06e620345d54 ("iommu/dma: Fix arch_sync_dma for map")
08ae5d4a1ae9 ("iommu/dma: Fix sync_sg with swiotlb")

Fixes tag

Fixes: 82612d66d51d ("iommu: Allow the iommu/dma api to use bounce buffers")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-09-30 00:43:23

by David Stevens

[permalink] [raw]

Subject: Re: linux-next: Fixes tags need some work in the iommu tree

---

On Thu, Sep 30, 2021 at 7:32 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commits
>
> 06e620345d54 ("iommu/dma: Fix arch_sync_dma for map")
> 08ae5d4a1ae9 ("iommu/dma: Fix sync_sg with swiotlb")

It looks like the Fixes messages got rewritten along with the tags in
the subject lines.

-David

> Fixes tag
>
> Fixes: 82612d66d51d ("iommu: Allow the iommu/dma api to use bounce buffers")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> --
> Cheers,
> Stephen Rothwell

2021-09-30 10:17:08

by Joerg Roedel

[permalink] [raw]

Subject: Re: linux-next: Fixes tags need some work in the iommu tree

---

On Thu, Sep 30, 2021 at 09:36:32AM +0900, David Stevens wrote:
> On Thu, Sep 30, 2021 at 7:32 AM Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commits
> >
> > 06e620345d54 ("iommu/dma: Fix arch_sync_dma for map")
> > 08ae5d4a1ae9 ("iommu/dma: Fix sync_sg with swiotlb")
>
> It looks like the Fixes messages got rewritten along with the tags in
> the subject lines.

Yeah, I edited the commit message so that the subject lines match the
IOMMU tree format. Apparently I changed the fixes tags by accident too,
will fix this up.

Regards,

Joerg