2021-09-30 12:49:10

by Dawid Esterhuizen

Subject: [PATCH v2] staging: rtl8712: Statements should start on a tabstop

This path fixes four checkpatch.pl warnings:

Statements should start on a tabstop

Changes since v1:
- Removed the volatile comments as they served no purpose
- Fixed the styling with corrected spacing as per checkpatch.pl
for easier reading

Signed-off-by: Dawid Esterhuizen <[email protected]>
---
drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index 2e6afc7bb0a1..cdcbc87a3cad 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -182,11 +182,11 @@ struct sta_xmit_priv {
};

struct hw_txqueue {
- /*volatile*/ sint head;
- /*volatile*/ sint tail;
- /*volatile*/ sint free_sz; /*in units of 64 bytes*/
- /*volatile*/ sint free_cmdsz;
- /*volatile*/ sint txsz[8];
+ sint head;
+ sint tail;
+ sint free_sz; /* in units of 64 bytes */
+ sint free_cmdsz;
+ sint txsz[8];
uint ff_hwaddr;
uint cmd_hwaddr;
sint ac_tag;
--
2.33.0

2021-09-30 14:36:19

by Dan Carpenter

Subject: Re: [PATCH v2] staging: rtl8712: Statements should start on a tabstop

On Thu, Sep 30, 2021 at 02:27:16PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
>
> Statements should start on a tabstop
>
> Changes since v1:
> - Removed the volatile comments as they served no purpose
> - Fixed the styling with corrected spacing as per checkpatch.pl
> for easier reading

This part goes under the --- cut off line

>
> Signed-off-by: Dawid Esterhuizen <[email protected]>
> ---
^^^
here.

Please send v3. ;)

regards,
dan carpenter