2021-10-02 16:37:37

by Saurav Girepunje

Subject: [PATCH v2] staging: r8188eu: core: remove unused variable pAdapter

Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

Signed-off-by: Saurav Girepunje <[email protected]>
---

ChangeLog V2:
-Remove unneeded line break on Efuse_Read1ByteFromFakeContenit().

ChangeLog V1:
-Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

drivers/staging/r8188eu/core/rtw_efuse.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
index 801887f497cf..225ebdee21c1 100644
--- a/drivers/staging/r8188eu/core/rtw_efuse.c
+++ b/drivers/staging/r8188eu/core/rtw_efuse.c
@@ -28,9 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
#define REG_EFUSE_CTRL 0x0030
#define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */

-static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
- u16 Offset,
- u8 *Value)
+static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
{
if (Offset >= EFUSE_MAX_HW_SIZE)
return false;
@@ -96,7 +94,7 @@ ReadEFuseByte(
u16 retry;

if (pseudo) {
- Efuse_Read1ByteFromFakeContent(Adapter, _offset, pbuf);
+ Efuse_Read1ByteFromFakeContent(_offset, pbuf);
return;
}

@@ -134,7 +132,7 @@ u8 efuse_OneByteRead(struct adapter *pAdapter, u16 addr, u8 *data, bool pseudo)
u8 result;

if (pseudo) {
- result = Efuse_Read1ByteFromFakeContent(pAdapter, addr, data);
+ result = Efuse_Read1ByteFromFakeContent(addr, data);
return result;
}
/* -----------------e-fuse reg ctrl --------------------------------- */
--
2.32.0

2021-10-03 10:49:23

by Michael Straube

Subject: Re: [PATCH v2] staging: r8188eu: core: remove unused variable pAdapter

On 10/2/21 18:34, Saurav Girepunje wrote:
> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
>
> ChangeLog V2:
> -Remove unneeded line break on Efuse_Read1ByteFromFakeContenit().
>
> ChangeLog V1:
> -Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>
> drivers/staging/r8188eu/core/rtw_efuse.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>

Looks good to me now.

Acked-by: Michael Straube <[email protected]>

Thanks,
Michael