Hi all,
These mails contain RFC patches, which are almost bug report and some
are just bug report, for atomisp to work (again). Tested on Microsoft
Surface 3 (Windows) and Xiaomi Mi Pad 2 (Android model) with v5.15-rc5.
Both are Cherry Trail (ISP2401) devices.
I'm still not used to Linux patch sending flow. Sorry in advance
if there is some weirdness :-) but I did my best.
To try to take a picture, take a look at the series I sent earlier named
("various fixes for atomisp to make it work")
The 1st patch is required to take a picture with atomsip (again):
[BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW
The 2nd patch is to avoid kernel warning message:
[BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid
duplicate active_bo
The 3rd patch is to avoid kernel oops, which is almost required for
using atomisp normally:
[BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from
atomisp_video_pipe
The 4th-5th mail is bug reports, no patches for these issues yet:
[BUG] media: atomisp: `modprobe -r` not working well (dup video4linux,
ATOMISP_SUBDEV_{0,1})
[BUG] media: atomisp: atomisp causes touchscreen to stop working on
Microsoft Surface 3
I added further descriptions at the top of each RFC/BUG mails.
Regards,
Tsuchiya Yuto
Tsuchiya Yuto (5):
[BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW
[BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid
duplicate active_bo
[BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from
atomisp_video_pipe
[BUG] media: atomisp: `modprobe -r` not working well (dup video4linux,
ATOMISP_SUBDEV_{0,1})
[BUG] media: atomisp: atomisp causes touchscreen to stop working on
Microsoft Surface 3
.../staging/media/atomisp/pci/atomisp_cmd.c | 73 ++++++++++++++
.../staging/media/atomisp/pci/atomisp_fops.c | 6 ++
.../staging/media/atomisp/pci/atomisp_ioctl.c | 96 ++++++++++++++++++-
drivers/staging/media/atomisp/pci/hmm/hmm.c | 4 -
4 files changed, 174 insertions(+), 5 deletions(-)
--
2.33.1
Hi All,
Just adding some folks to the Cc.
Regards,
Hans
On 10/17/21 18:23, Tsuchiya Yuto wrote:
> Hi all,
>
> These mails contain RFC patches, which are almost bug report and some
> are just bug report, for atomisp to work (again). Tested on Microsoft
> Surface 3 (Windows) and Xiaomi Mi Pad 2 (Android model) with v5.15-rc5.
> Both are Cherry Trail (ISP2401) devices.
>
> I'm still not used to Linux patch sending flow. Sorry in advance
> if there is some weirdness :-) but I did my best.
>
> To try to take a picture, take a look at the series I sent earlier named
> ("various fixes for atomisp to make it work")
>
> The 1st patch is required to take a picture with atomsip (again):
>
> [BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW
>
> The 2nd patch is to avoid kernel warning message:
>
> [BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid
> duplicate active_bo
>
> The 3rd patch is to avoid kernel oops, which is almost required for
> using atomisp normally:
>
> [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from
> atomisp_video_pipe
>
> The 4th-5th mail is bug reports, no patches for these issues yet:
>
> [BUG] media: atomisp: `modprobe -r` not working well (dup video4linux,
> ATOMISP_SUBDEV_{0,1})
> [BUG] media: atomisp: atomisp causes touchscreen to stop working on
> Microsoft Surface 3
>
> I added further descriptions at the top of each RFC/BUG mails.
>
> Regards,
> Tsuchiya Yuto
>
> Tsuchiya Yuto (5):
> [BUG][RFC] media: atomisp: pci: assume run_mode is PREVIEW
> [BUG][RFC] media: atomisp: pci: remove dummy_ptr NULL check to avoid
> duplicate active_bo
> [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from
> atomisp_video_pipe
> [BUG] media: atomisp: `modprobe -r` not working well (dup video4linux,
> ATOMISP_SUBDEV_{0,1})
> [BUG] media: atomisp: atomisp causes touchscreen to stop working on
> Microsoft Surface 3
>
> .../staging/media/atomisp/pci/atomisp_cmd.c | 73 ++++++++++++++
> .../staging/media/atomisp/pci/atomisp_fops.c | 6 ++
> .../staging/media/atomisp/pci/atomisp_ioctl.c | 96 ++++++++++++++++++-
> drivers/staging/media/atomisp/pci/hmm/hmm.c | 4 -
> 4 files changed, 174 insertions(+), 5 deletions(-)
>
On Mon, Oct 18, 2021 at 10:51 AM Hans de Goede <[email protected]> wrote:
> Just adding some folks to the Cc.
A hint to the newly added folks, there is an archive of the Linux
kernel related emails located on lore.kernel.org. The quite famous
distros already have in their repositories the `b4` tool that helps to
access that archive. So, after installing that tool you may download
the whole thread as a mailbox or as a bundle ready for `git am` just
using the Message-ID value.
--
With Best Regards,
Andy Shevchenko
On Mon, 2021-10-18 at 11:10 +0300, Andy Shevchenko wrote:
> On Mon, Oct 18, 2021 at 10:51 AM Hans de Goede <[email protected]> wrote:
>
> > Just adding some folks to the Cc.
>
> A hint to the newly added folks, there is an archive of the Linux
> kernel related emails located on lore.kernel.org. The quite famous
> distros already have in their repositories the `b4` tool that helps to
> access that archive. So, after installing that tool you may download
> the whole thread as a mailbox or as a bundle ready for `git am` just
> using the Message-ID value.
Ah sorry, I failed to add people to Cc who I should have definitly
added.
And I might have sent all of the emails to people who I should not
by blindly using `scripts/get_maintainer.pl` for the first bug report
with `--cc-cmd`.
Sorry if that's the case for some of you...
Regards,
Tsuchiya Yuto
On Tue, Oct 19, 2021 at 09:58:20PM +0900, Tsuchiya Yuto wrote:
> On Mon, 2021-10-18 at 11:10 +0300, Andy Shevchenko wrote:
> > On Mon, Oct 18, 2021 at 10:51 AM Hans de Goede <[email protected]> wrote:
> >
> > > Just adding some folks to the Cc.
> >
> > A hint to the newly added folks, there is an archive of the Linux
> > kernel related emails located on lore.kernel.org. The quite famous
> > distros already have in their repositories the `b4` tool that helps to
> > access that archive. So, after installing that tool you may download
> > the whole thread as a mailbox or as a bundle ready for `git am` just
> > using the Message-ID value.
>
> Ah sorry, I failed to add people to Cc who I should have definitly
> added.
>
> And I might have sent all of the emails to people who I should not
> by blindly using `scripts/get_maintainer.pl` for the first bug report
> with `--cc-cmd`.
I have written a script [1] for myself which helps me a lot nowadays.
It tries to be smart enough to include all interested parties. Although,
user may expand the Cc and/or To lists.
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
Em Mon, 18 Oct 2021 01:23:31 +0900
Tsuchiya Yuto <[email protected]> escreveu:
> Hi all,
>
> These mails contain RFC patches, which are almost bug report and some
> are just bug report, for atomisp to work (again). Tested on Microsoft
> Surface 3 (Windows) and Xiaomi Mi Pad 2 (Android model) with v5.15-rc5.
> Both are Cherry Trail (ISP2401) devices.
Before start looking at the patches, let me check if I got it right:
Should this series be applied after the series you sent earlier[1]?
[1] The series which starts with this one:
[PATCH 00/17] various fixes for atomisp to make it work
Regards,
Mauro
On Wed, 2021-10-20 at 07:48 +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 18 Oct 2021 01:23:31 +0900
> Tsuchiya Yuto <[email protected]> escreveu:
>
> > Hi all,
> >
> > These mails contain RFC patches, which are almost bug report and some
> > are just bug report, for atomisp to work (again). Tested on Microsoft
> > Surface 3 (Windows) and Xiaomi Mi Pad 2 (Android model) with v5.15-rc5.
> > Both are Cherry Trail (ISP2401) devices.
>
> Before start looking at the patches, let me check if I got it right:
>
> Should this series be applied after the series you sent earlier[1]?
>
> [1] The series which starts with this one:
> [PATCH 00/17] various fixes for atomisp to make it work
Hi, thank you for looking into this.
This series (RFC patches and BUG reports) does not depend on the series
I sent earlier ("various fixes for atomisp to make it work"). So, these
bugs here can be looked into anytime.
Especially, the bug that causes NULL pointer dereference on some setup
("[BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for
asd obtained from atomisp_video_pipe") is somewhat a critical issue and
it'd be great if it's fixed in a proper way as soon as possible.
Regards,
Tsuchiya Yuto