2021-10-25 10:06:15

by Jiasheng Jiang

Subject: Re: Re: [PATCH] sched: Fix implicit type conversion

On Mon, Oct 25, 2021 at 08:57:31AM +0000, Peter Zijlstra wrote:
>> The variable 'n' is defined as ULONG. However in the cpumask_next(),
>> it is used as INT.
>> That is vulnerable and may cause overflow.
>> Therefore, it might be better to define 'n' as INT.

>-ENOPARSE

I don't understand the 'ENOPARSE'.
Please give me more details.

2021-10-25 11:29:52

by Peter Zijlstra

Subject: Re: Re: [PATCH] sched: Fix implicit type conversion

On Mon, Oct 25, 2021 at 10:00:00AM +0000, Jiasheng Jiang wrote:
> On Mon, Oct 25, 2021 at 08:57:31AM +0000, Peter Zijlstra wrote:
> >> The variable 'n' is defined as ULONG. However in the cpumask_next(),
> >> it is used as INT.
> >> That is vulnerable and may cause overflow.
> >> Therefore, it might be better to define 'n' as INT.
>
> >-ENOPARSE
>
> I don't understand the 'ENOPARSE'.
> Please give me more details.

I've no idea what your changelog is trying to say, or how your patch
makes a difference.