2021-11-11 23:09:00

by Mauro Carvalho Chehab

Subject: [PATCH 1/3] media: ipu3: drop an unused variable

Fix this clang Werror with W=1:

drivers/staging/media/ipu3/ipu3-css-params.c:774:8: error: variable 'pin_scale' set but not used [-Werror,-Wunused-but-set-variable]
int pin_scale = 0;
^

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 0/3] at: https://lore.kernel.org/all/[email protected]/

drivers/staging/media/ipu3/ipu3-css-params.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index e9d6bd9e9332..d9e3c3785075 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -771,7 +771,6 @@ static int imgu_css_osys_calc_frame_and_stripe_params(
*/
{
unsigned int i;
- int pin_scale = 0;
/*Input resolution */

stripe_params[s].input_width = stripe_input_width_y;
@@ -791,8 +790,6 @@ static int imgu_css_osys_calc_frame_and_stripe_params(
reso.pin_height[i];
stripe_params[s].output_offset[i] =
stripe_offset_out_y;
-
- pin_scale += frame_params[i].scaled;
} else {
/* Unscaled pin */
stripe_params[s].output_width[i] =
--
2.33.1

2021-11-12 20:44:03

by Nathan Chancellor

Subject: Re: [PATCH 1/3] media: ipu3: drop an unused variable

On Thu, Nov 11, 2021 at 11:08:51PM +0000, Mauro Carvalho Chehab wrote:
> Fix this clang Werror with W=1:
>
> drivers/staging/media/ipu3/ipu3-css-params.c:774:8: error: variable 'pin_scale' set but not used [-Werror,-Wunused-but-set-variable]
> int pin_scale = 0;
> ^
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
>
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 0/3] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/staging/media/ipu3/ipu3-css-params.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index e9d6bd9e9332..d9e3c3785075 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -771,7 +771,6 @@ static int imgu_css_osys_calc_frame_and_stripe_params(
> */
> {
> unsigned int i;
> - int pin_scale = 0;
> /*Input resolution */
>
> stripe_params[s].input_width = stripe_input_width_y;
> @@ -791,8 +790,6 @@ static int imgu_css_osys_calc_frame_and_stripe_params(
> reso.pin_height[i];
> stripe_params[s].output_offset[i] =
> stripe_offset_out_y;
> -
> - pin_scale += frame_params[i].scaled;
> } else {
> /* Unscaled pin */
> stripe_params[s].output_width[i] =
> --
> 2.33.1
>
>

2021-11-16 12:57:19

by Sakari Ailus

Subject: Re: [PATCH 1/3] media: ipu3: drop an unused variable

On Thu, Nov 11, 2021 at 11:08:51PM +0000, Mauro Carvalho Chehab wrote:
> Fix this clang Werror with W=1:
>
> drivers/staging/media/ipu3/ipu3-css-params.c:774:8: error: variable 'pin_scale' set but not used [-Werror,-Wunused-but-set-variable]
> int pin_scale = 0;
> ^
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Thanks!

Acked-by: Sakari Ailus <[email protected]>

I.e. feel free to merge through your tree, I don't think there's a chance
for conflicts here.

--
Sakari Ailus