2021-11-13 06:53:59

by Wilken Gottwalt

Subject: [PATCH] hwmon: corsair-psu: fix plain integer used as NULL pointer

sparse warnings: (new ones prefixed by >>)
>> drivers/hwmon/corsair-psu.c:536:82: sparse: sparse: Using plain
integer as NULL pointer

Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Wilken Gottwalt <[email protected]>
---
drivers/hwmon/corsair-psu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index 731d5117f9f1..14389fd7afb8 100644
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -729,7 +729,7 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id
corsairpsu_check_cmd_support(priv);

priv->hwmon_dev = hwmon_device_register_with_info(&hdev->dev, "corsairpsu", priv,
- &corsairpsu_chip_info, 0);
+ &corsairpsu_chip_info, NULL);

if (IS_ERR(priv->hwmon_dev)) {
ret = PTR_ERR(priv->hwmon_dev);
--
2.33.1

2021-11-14 16:52:21

by Guenter Roeck

Subject: Re: [PATCH] hwmon: corsair-psu: fix plain integer used as NULL pointer

On Sat, Nov 13, 2021 at 06:53:52AM +0000, Wilken Gottwalt wrote:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/hwmon/corsair-psu.c:536:82: sparse: sparse: Using plain
> integer as NULL pointer
>
> Fixes: d115b51e0e56 ("hwmon: add Corsair PSU HID controller driver")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Wilken Gottwalt <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/corsair-psu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index 731d5117f9f1..14389fd7afb8 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -729,7 +729,7 @@ static int corsairpsu_probe(struct hid_device *hdev, const struct hid_device_id
> corsairpsu_check_cmd_support(priv);
>
> priv->hwmon_dev = hwmon_device_register_with_info(&hdev->dev, "corsairpsu", priv,
> - &corsairpsu_chip_info, 0);
> + &corsairpsu_chip_info, NULL);
>
> if (IS_ERR(priv->hwmon_dev)) {
> ret = PTR_ERR(priv->hwmon_dev);