2021-11-03 05:57:54

by CGEL

Subject: [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.

From: Zhang Mingyu <[email protected]>

This issue was detected with the help of Coccinelle.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Zhang Mingyu <[email protected]>
---
arch/s390/mm/fault.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
index d30f5986fa85..48a0231158c9 100644
--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -824,8 +824,7 @@ void do_secure_storage_access(struct pt_regs *regs)
break;
rc = arch_make_page_accessible(page);
put_page(page);
- if (rc)
- BUG();
+ BUG_ON(rc);
break;
case GMAP_FAULT:
default:
--
2.25.1

2021-11-10 14:47:36

by Heiko Carstens

Subject: Re: [PATCH] s390:Use BUG_ON instead of if condition followed by BUG.

On Wed, Nov 03, 2021 at 05:56:22AM +0000, [email protected] wrote:
> From: Zhang Mingyu <[email protected]>
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Zhang Mingyu <[email protected]>
> ---
> arch/s390/mm/fault.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

S-O-B chain is incorrect. Sent by [email protected], but not listed
anywhere. Therefore not applying.