BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
clk_get_parent(), so add a simple implementation of that
function so that callers of it will build without errors.
Fixes these build errors:
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Artur Rojek <[email protected]>
Cc: Paul Cercueil <[email protected]>
Cc: [email protected]
Cc: Jonathan Cameron <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: [email protected]
Cc: Florian Fainelli <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Russell King <[email protected]>
Cc: [email protected]
Cc: Jonas Gorski <[email protected]>
---
v1 and v2 were:
[PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
arch/mips/bcm63xx/clk.c | 7 +++++++
1 file changed, 7 insertions(+)
--- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
+++ linux-next-20211112/arch/mips/bcm63xx/clk.c
@@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
EXPORT_SYMBOL(clk_disable);
+struct clk *clk_get_parent(struct clk *clk)
+{
+ return NULL;
+}
+
+EXPORT_SYMBOL(clk_get_parent);
+
unsigned long clk_get_rate(struct clk *clk)
{
if (!clk)
On Sun, Nov 14, 2021 at 6:34 PM Randy Dunlap <[email protected]> wrote:
>
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
Some nit-picks below.
Otherwise looks good to me,
Reviewed-by: Andy Shevchenko <[email protected]>
Suggested-by?
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Artur Rojek <[email protected]>
> Cc: Paul Cercueil <[email protected]>
> Cc: [email protected]
> Cc: Jonathan Cameron <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: [email protected]
> Cc: Florian Fainelli <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: [email protected]
> Cc: Jonas Gorski <[email protected]>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
Not sure why it's here. What does (the location of) this tag mean?
> arch/mips/bcm63xx/clk.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>
> EXPORT_SYMBOL(clk_disable);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +
Perhaps it's not needed even if the rest have it (I mean blank line).
> +EXPORT_SYMBOL(clk_get_parent);
> +
> unsigned long clk_get_rate(struct clk *clk)
> {
> if (!clk)
--
With Best Regards,
Andy Shevchenko
On Sun, 14 Nov 2021 08:34:44 -0800
Randy Dunlap <[email protected]> wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>
I wonder a bit if it makes sense to fix only the ones we hit given there
look to be other missing definitions in this subarch.
clk_has_parent() for example appears to also be missing.
Do we have the same issue with mips/lantiq?
Jonathan
> Cc: Artur Rojek <[email protected]>
> Cc: Paul Cercueil <[email protected]>
> Cc: [email protected]
> Cc: Jonathan Cameron <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: [email protected]
> Cc: Florian Fainelli <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: [email protected]
> Cc: Jonas Gorski <[email protected]>
> ---
> v1 and v2 were:
> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
>
> arch/mips/bcm63xx/clk.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>
> EXPORT_SYMBOL(clk_disable);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +
> +EXPORT_SYMBOL(clk_get_parent);
> +
> unsigned long clk_get_rate(struct clk *clk)
> {
> if (!clk)
On Sun, Nov 14, 2021 at 08:34:44AM -0800, Randy Dunlap wrote:
> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
> clk_get_parent(), so add a simple implementation of that
> function so that callers of it will build without errors.
>
> Fixes these build errors:
>
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Acked-by: Russell King (Oracle) <[email protected]>
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
On 11/14/21 8:59 AM, Jonathan Cameron wrote:
> On Sun, 14 Nov 2021 08:34:44 -0800
> Randy Dunlap <[email protected]> wrote:
>
>> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
>> clk_get_parent(), so add a simple implementation of that
>> function so that callers of it will build without errors.
>>
>> Fixes these build errors:
>>
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Reported-by: kernel test robot <[email protected]>
>
> Acked-by: Jonathan Cameron <[email protected]>
>
> I wonder a bit if it makes sense to fix only the ones we hit given there
> look to be other missing definitions in this subarch.
> clk_has_parent() for example appears to also be missing.
I haven't seen any failures for clk_has_parent().
I'm not actively looking for build errors; I'm just fixing
reported problems (usually and in this case).
There are plenty of them being reported without me having
to go looking for more.
> Do we have the same issue with mips/lantiq?
Yes, now that you made me look. :)
Now I'll have to send a patch for that subarch also.
--
~Randy
On 11/14/21 8:40 AM, Andy Shevchenko wrote:
> On Sun, Nov 14, 2021 at 6:34 PM Randy Dunlap <[email protected]> wrote:
>>
>> BCM63XX selects HAVE_LEGACY_CLK but does not provide/support
>> clk_get_parent(), so add a simple implementation of that
>> function so that callers of it will build without errors.
>>
>> Fixes these build errors:
>>
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4770_adc_init_clk_div':
>> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
>> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function `jz4725b_adc_init_clk_div':
>> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
>
> Some nit-picks below.
> Otherwise looks good to me,
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> Suggested-by?
Yes, I'll add Russell for that.
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Reported-by: kernel test robot <[email protected]>
>> Cc: Artur Rojek <[email protected]>
>> Cc: Paul Cercueil <[email protected]>
>> Cc: [email protected]
>> Cc: Jonathan Cameron <[email protected]>
>> Cc: Lars-Peter Clausen <[email protected]>
>> Cc: [email protected]
>> Cc: Florian Fainelli <[email protected]>
>> Cc: Andy Shevchenko <[email protected]>
>> Cc: Russell King <[email protected]>
>> Cc: [email protected]
>> Cc: Jonas Gorski <[email protected]>
>> ---
>> v1 and v2 were:
>> [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors
>
>> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
>
> Not sure why it's here. What does (the location of) this tag mean?
Yesterday I didn't see what Fixes: tag I should use,
but after looking again, it looks like I should use
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs."
>
>> arch/mips/bcm63xx/clk.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> --- linux-next-20211112.orig/arch/mips/bcm63xx/clk.c
>> +++ linux-next-20211112/arch/mips/bcm63xx/clk.c
>> @@ -381,6 +381,13 @@ void clk_disable(struct clk *clk)
>>
>> EXPORT_SYMBOL(clk_disable);
>>
>> +struct clk *clk_get_parent(struct clk *clk)
>> +{
>> + return NULL;
>> +}
>
>> +
>
> Perhaps it's not needed even if the rest have it (I mean blank line).
Sure, I'll drop it. It was for file consistency,
but it's not a big deal either way.
>> +EXPORT_SYMBOL(clk_get_parent);
>> +
>> unsigned long clk_get_rate(struct clk *clk)
>> {
>> if (!clk)
>
Thanks.
--
~Randy