2021-06-24 18:34:55

by Sibi Sankar

Subject: [PATCH] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350
SoC.

Fixes: e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
Signed-off-by: Sibi Sankar <[email protected]>
Cc: [email protected]
---

The device tree and pas documentation lists mcx as a required pd for cdsp.
Looks like it was missed while adding the proxy pds in the pas driver.
Bjorn/Vinod you'll need to test this patch before picking it up.

drivers/remoteproc/qcom_q6v5_pas.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index b921fc26cd04..ad20065dbdea 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -661,6 +661,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
},
.proxy_pd_names = (char*[]){
"cx",
+ "mxc",
NULL
},
.ssr_name = "cdsp",
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-11-17 18:57:31

by Bjorn Andersson

Subject: Re: [PATCH] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

On Thu 24 Jun 13:33 CDT 2021, Sibi Sankar wrote:

> Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350
> SoC.
>
> Fixes: e8b4e9a21af7 ("remoteproc: qcom: pas: Add SM8350 PAS remoteprocs")
> Signed-off-by: Sibi Sankar <[email protected]>
> Cc: [email protected]
> ---
>
> The device tree and pas documentation lists mcx as a required pd for cdsp.
> Looks like it was missed while adding the proxy pds in the pas driver.
> Bjorn/Vinod you'll need to test this patch before picking it up.
>

At least on the HDK mxc seems to be optional given the current system
state, but I don't see any regressions so let's land this before we put
the system in a state where it would matter.

Tested-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index b921fc26cd04..ad20065dbdea 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -661,6 +661,7 @@ static const struct adsp_data sm8350_cdsp_resource = {
> },
> .proxy_pd_names = (char*[]){
> "cx",
> + "mxc",
> NULL
> },
> .ssr_name = "cdsp",
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

2021-12-15 22:44:59

by Bjorn Andersson

Subject: Re: (subset) [PATCH] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP

On Fri, 25 Jun 2021 00:03:25 +0530, Sibi Sankar wrote:
> Add missing power-domain "mxc" required by CDSP PAS remoteproc on SM8350
> SoC.
>
>

Applied, thanks!

[1/1] remoteproc: qcom: pas: Add missing power-domain "mxc" for CDSP
commit: dd585d9bfbf06fd08a6326c82978be1f06e7d1bd

Best regards,
--
Bjorn Andersson <[email protected]>