2021-11-17 00:39:16

by Liam Beguin

Subject: [PATCH 1/1] dt-bindings: phy: zynqmp-psgtr: fix USB phy name

PHY_TYPE_USB is undefined and was added as PHY_TYPE_USB2 and
PHY_TYPE_USB3 in 2fbbc96d1600 (phy: Add PHY header file for DT x Driver
defines, 2014-11-04). Fix documentation to avoid misleading users.

Signed-off-by: Liam Beguin <[email protected]>
---
Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
index 04d5654efb38..79906519c652 100644
--- a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
+++ b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
@@ -29,7 +29,7 @@ properties:
- PHY_TYPE_PCIE
- PHY_TYPE_SATA
- PHY_TYPE_SGMII
- - PHY_TYPE_USB
+ - PHY_TYPE_USB3
- description: The PHY instance
minimum: 0
maximum: 1 # for DP, SATA or USB
--
2.34.0

2021-11-17 07:50:56

by Laurent Pinchart

Subject: Re: [PATCH 1/1] dt-bindings: phy: zynqmp-psgtr: fix USB phy name

Hi Liam,

Thank you for the patch.

On Tue, Nov 16, 2021 at 07:38:41PM -0500, Liam Beguin wrote:
> PHY_TYPE_USB is undefined and was added as PHY_TYPE_USB2 and
> PHY_TYPE_USB3 in 2fbbc96d1600 (phy: Add PHY header file for DT x Driver
> defines, 2014-11-04). Fix documentation to avoid misleading users.
>
> Signed-off-by: Liam Beguin <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> index 04d5654efb38..79906519c652 100644
> --- a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> +++ b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> @@ -29,7 +29,7 @@ properties:
> - PHY_TYPE_PCIE
> - PHY_TYPE_SATA
> - PHY_TYPE_SGMII
> - - PHY_TYPE_USB
> + - PHY_TYPE_USB3
> - description: The PHY instance
> minimum: 0
> maximum: 1 # for DP, SATA or USB

--
Regards,

Laurent Pinchart

2021-11-23 05:11:48

by Vinod Koul

Subject: Re: [PATCH 1/1] dt-bindings: phy: zynqmp-psgtr: fix USB phy name

On 16-11-21, 19:38, Liam Beguin wrote:
> PHY_TYPE_USB is undefined and was added as PHY_TYPE_USB2 and
> PHY_TYPE_USB3 in 2fbbc96d1600 (phy: Add PHY header file for DT x Driver
> defines, 2014-11-04). Fix documentation to avoid misleading users.

Applied, thanks

>
> Signed-off-by: Liam Beguin <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> index 04d5654efb38..79906519c652 100644
> --- a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> +++ b/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
> @@ -29,7 +29,7 @@ properties:
> - PHY_TYPE_PCIE
> - PHY_TYPE_SATA
> - PHY_TYPE_SGMII
> - - PHY_TYPE_USB
> + - PHY_TYPE_USB3
> - description: The PHY instance
> minimum: 0
> maximum: 1 # for DP, SATA or USB
> --
> 2.34.0

--
~Vinod