2021-11-24 19:13:41

by Mauro Carvalho Chehab

Subject: [PATCH 06/20] media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk()

This vaklue is never used at the code. So, drop it.

Solves a W=1 clang warning.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/

drivers/media/dvb-frontends/m88ds3103.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index 02e8aa11e36e..bce0f42f3d19 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -451,7 +451,7 @@ static int m88ds3103b_select_mclk(struct m88ds3103_dev *dev)

static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
{
- u8 reg11 = 0x0A, reg15, reg16, reg1D, reg1E, reg1F, tmp;
+ u8 reg15, reg16, reg1D, reg1E, reg1F, tmp;
u8 sm, f0 = 0, f1 = 0, f2 = 0, f3 = 0;
u16 pll_div_fb, N;
u32 div;
@@ -480,8 +480,6 @@ static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
div /= mclk_khz;

if (dev->cfg->ts_mode == M88DS3103_TS_SERIAL) {
- reg11 |= 0x02;
-
if (div <= 32) {
N = 2;

@@ -532,8 +530,6 @@ static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
else if ((f3 < 8) && (f3 != 0))
f3 = 8;
} else {
- reg11 &= ~0x02;
-
if (div <= 32) {
N = 2;

--
2.33.1

2021-11-26 19:43:04

by Nathan Chancellor

Subject: Re: [PATCH 06/20] media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk()

On Wed, Nov 24, 2021 at 08:13:09PM +0100, Mauro Carvalho Chehab wrote:
> This vaklue is never used at the code. So, drop it.

^ value

> Solves a W=1 clang warning.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

I would expect GCC to warn about this as well.

> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/media/dvb-frontends/m88ds3103.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
> index 02e8aa11e36e..bce0f42f3d19 100644
> --- a/drivers/media/dvb-frontends/m88ds3103.c
> +++ b/drivers/media/dvb-frontends/m88ds3103.c
> @@ -451,7 +451,7 @@ static int m88ds3103b_select_mclk(struct m88ds3103_dev *dev)
>
> static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
> {
> - u8 reg11 = 0x0A, reg15, reg16, reg1D, reg1E, reg1F, tmp;
> + u8 reg15, reg16, reg1D, reg1E, reg1F, tmp;
> u8 sm, f0 = 0, f1 = 0, f2 = 0, f3 = 0;
> u16 pll_div_fb, N;
> u32 div;
> @@ -480,8 +480,6 @@ static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
> div /= mclk_khz;
>
> if (dev->cfg->ts_mode == M88DS3103_TS_SERIAL) {
> - reg11 |= 0x02;
> -
> if (div <= 32) {
> N = 2;
>
> @@ -532,8 +530,6 @@ static int m88ds3103b_set_mclk(struct m88ds3103_dev *dev, u32 mclk_khz)
> else if ((f3 < 8) && (f3 != 0))
> f3 = 8;
> } else {
> - reg11 &= ~0x02;
> -
> if (div <= 32) {
> N = 2;
>
> --
> 2.33.1
>
>