2021-11-24 19:13:39

by Mauro Carvalho Chehab

Subject: [PATCH 03/20] media: davinci: get rid of an unused function

vpif_get_default_field() seems to be some left-over from a
past code that sets the field order.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/

drivers/media/platform/davinci/vpif_capture.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index ae92e2c206d0..aba105fa7ef9 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -618,17 +618,6 @@ static void vpif_calculate_offsets(struct channel_obj *ch)
ch->vpifparams.video_params.stdid = vpifparams->std_info.stdid;
}

-/**
- * vpif_get_default_field() - Get default field type based on interface
- * @iface: ptr to vpif interface
- */
-static inline enum v4l2_field vpif_get_default_field(
- struct vpif_interface *iface)
-{
- return (iface->if_type == VPIF_IF_RAW_BAYER) ? V4L2_FIELD_NONE :
- V4L2_FIELD_INTERLACED;
-}
-
/**
* vpif_config_addr() - function to configure buffer address in vpif
* @ch: channel ptr
--
2.33.1

2021-11-26 19:08:39

by Nathan Chancellor

Subject: Re: [PATCH 03/20] media: davinci: get rid of an unused function

On Wed, Nov 24, 2021 at 08:13:06PM +0100, Mauro Carvalho Chehab wrote:
> vpif_get_default_field() seems to be some left-over from a
> past code that sets the field order.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/media/platform/davinci/vpif_capture.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
> index ae92e2c206d0..aba105fa7ef9 100644
> --- a/drivers/media/platform/davinci/vpif_capture.c
> +++ b/drivers/media/platform/davinci/vpif_capture.c
> @@ -618,17 +618,6 @@ static void vpif_calculate_offsets(struct channel_obj *ch)
> ch->vpifparams.video_params.stdid = vpifparams->std_info.stdid;
> }
>
> -/**
> - * vpif_get_default_field() - Get default field type based on interface
> - * @iface: ptr to vpif interface
> - */
> -static inline enum v4l2_field vpif_get_default_field(
> - struct vpif_interface *iface)
> -{
> - return (iface->if_type == VPIF_IF_RAW_BAYER) ? V4L2_FIELD_NONE :
> - V4L2_FIELD_INTERLACED;
> -}
> -
> /**
> * vpif_config_addr() - function to configure buffer address in vpif
> * @ch: channel ptr
> --
> 2.33.1
>
>