2021-11-24 19:13:33

by Mauro Carvalho Chehab

Subject: [PATCH 01/20] media: adv7842: get rid of two unused functions

Those functions just call a V4L2 core macro, and aren't used
anywhere. Get rid of them, in order to avoid clang warnings with
W=1.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/

drivers/media/i2c/adv7842.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
index 7f8acbdf0db4..9d6eed0f8281 100644
--- a/drivers/media/i2c/adv7842.c
+++ b/drivers/media/i2c/adv7842.c
@@ -256,21 +256,11 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl)
return &container_of(ctrl->handler, struct adv7842_state, hdl)->sd;
}

-static inline unsigned hblanking(const struct v4l2_bt_timings *t)
-{
- return V4L2_DV_BT_BLANKING_WIDTH(t);
-}
-
static inline unsigned htotal(const struct v4l2_bt_timings *t)
{
return V4L2_DV_BT_FRAME_WIDTH(t);
}

-static inline unsigned vblanking(const struct v4l2_bt_timings *t)
-{
- return V4L2_DV_BT_BLANKING_HEIGHT(t);
-}
-
static inline unsigned vtotal(const struct v4l2_bt_timings *t)
{
return V4L2_DV_BT_FRAME_HEIGHT(t);
--
2.33.1

2021-11-26 18:57:08

by Nathan Chancellor

Subject: Re: [PATCH 01/20] media: adv7842: get rid of two unused functions

On Wed, Nov 24, 2021 at 08:13:04PM +0100, Mauro Carvalho Chehab wrote:
> Those functions just call a V4L2 core macro, and aren't used
> anywhere. Get rid of them, in order to avoid clang warnings with
> W=1.
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/media/i2c/adv7842.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
> index 7f8acbdf0db4..9d6eed0f8281 100644
> --- a/drivers/media/i2c/adv7842.c
> +++ b/drivers/media/i2c/adv7842.c
> @@ -256,21 +256,11 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl)
> return &container_of(ctrl->handler, struct adv7842_state, hdl)->sd;
> }
>
> -static inline unsigned hblanking(const struct v4l2_bt_timings *t)
> -{
> - return V4L2_DV_BT_BLANKING_WIDTH(t);
> -}
> -
> static inline unsigned htotal(const struct v4l2_bt_timings *t)
> {
> return V4L2_DV_BT_FRAME_WIDTH(t);
> }
>
> -static inline unsigned vblanking(const struct v4l2_bt_timings *t)
> -{
> - return V4L2_DV_BT_BLANKING_HEIGHT(t);
> -}
> -
> static inline unsigned vtotal(const struct v4l2_bt_timings *t)
> {
> return V4L2_DV_BT_FRAME_HEIGHT(t);
> --
> 2.33.1
>
>