2021-12-09 12:30:37

by Andy Shevchenko

Subject: [PATCH v1 1/1] percpu_ref: Replace kernel.h with the necessary inclusions

When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.

Replace kernel.h inclusion with the list of what is really being used.

Signed-off-by: Andy Shevchenko <[email protected]>
---
include/linux/percpu-refcount.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
index b31d3f3312ce..d73a1c08c3e3 100644
--- a/include/linux/percpu-refcount.h
+++ b/include/linux/percpu-refcount.h
@@ -51,9 +51,9 @@
#define _LINUX_PERCPU_REFCOUNT_H

#include <linux/atomic.h>
-#include <linux/kernel.h>
#include <linux/percpu.h>
#include <linux/rcupdate.h>
+#include <linux/types.h>
#include <linux/gfp.h>

struct percpu_ref;
--
2.33.0

2021-12-09 20:40:11

by Dennis Zhou

Subject: Re: [PATCH v1 1/1] percpu_ref: Replace kernel.h with the necessary inclusions

Hello,

On Thu, Dec 09, 2021 at 02:30:33PM +0200, Andy Shevchenko wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> include/linux/percpu-refcount.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h
> index b31d3f3312ce..d73a1c08c3e3 100644
> --- a/include/linux/percpu-refcount.h
> +++ b/include/linux/percpu-refcount.h
> @@ -51,9 +51,9 @@
> #define _LINUX_PERCPU_REFCOUNT_H
>
> #include <linux/atomic.h>
> -#include <linux/kernel.h>
> #include <linux/percpu.h>
> #include <linux/rcupdate.h>
> +#include <linux/types.h>
> #include <linux/gfp.h>
>
> struct percpu_ref;
> --
> 2.33.0
>

Applied to for-5.16-fixes.

Thanks,
Dennis