2021-12-08 07:57:13

by CGEL

Subject: [PATCH linux-next] netfilter: Remove useless assignment statements

From: luo penghao <[email protected]>

The old_size assignment here will not be used anymore

The clang_analyzer complains as follows:

Value stored to 'old_size' is never read

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
net/netfilter/nf_conntrack_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index 770a631..1c786a4 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -2590,7 +2590,6 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
hlist_nulls_add_head_rcu(&h->hnnode, &hash[bucket]);
}
}
- old_size = nf_conntrack_htable_size;
old_hash = nf_conntrack_hash;

nf_conntrack_hash = hash;
--
2.15.2

2021-12-15 23:19:01

by Pablo Neira Ayuso

Subject: Re: [PATCH linux-next] netfilter: Remove useless assignment statements

On Wed, Dec 08, 2021 at 07:57:06AM +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The old_size assignment here will not be used anymore
>
> The clang_analyzer complains as follows:
>
> Value stored to 'old_size' is never read

Applied