The pointer link is being re-assigned the same value that it was
initialized with in the previous declaration statement. The
re-assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <[email protected]>
---
net/smc/smc_clc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
index 8409ab71a5e4..6be95a2a7b25 100644
--- a/net/smc/smc_clc.c
+++ b/net/smc/smc_clc.c
@@ -1021,7 +1021,6 @@ static int smc_clc_send_confirm_accept(struct smc_sock *smc,
struct smc_link *link = conn->lnk;
/* SMC-R specific settings */
- link = conn->lnk;
memcpy(clc->hdr.eyecatcher, SMC_EYECATCHER,
sizeof(SMC_EYECATCHER));
clc->hdr.typev1 = SMC_TYPE_R;
--
2.33.1
On Thu, Dec 30, 2021 at 03:39:00PM +0000, Colin Ian King wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
It would be better to add Fixes statement in the end of message.
Fixes: 387707fdf486 ("net/smc: convert static link ID to dynamic references")
And [PATCH net ...] is fine to point out the target. The patch itself
looks good to me, thanks.
Reviewed-by: Tony Lu <[email protected]>
Thanks,
Tony Lu
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:
On Thu, 30 Dec 2021 15:39:00 +0000 you wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> net/smc/smc_clc.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- net/smc: remove redundant re-assignment of pointer link
https://git.kernel.org/netdev/net-next/c/3a856c14c31b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html