2021-12-27 09:45:51

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH v2 03/23] counter: microchip-tcb-capture: Drop unused platform_set_drvdata()

The driver doesn't ever use platform_get_drvdata, so drop this unused
call.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/counter/microchip-tcb-capture.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
index 0ab1b2716784..bb69f2e0ba93 100644
--- a/drivers/counter/microchip-tcb-capture.c
+++ b/drivers/counter/microchip-tcb-capture.c
@@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;

- platform_set_drvdata(pdev, priv);
-
match = of_match_node(atmel_tc_of_match, np->parent);
tcb_config = match->data;
if (!tcb_config) {
--
2.33.0



2021-12-28 17:32:39

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v2 03/23] counter: microchip-tcb-capture: Drop unused platform_set_drvdata()

On Mon, 27 Dec 2021 10:45:06 +0100
Uwe Kleine-König <[email protected]> wrote:

> The driver doesn't ever use platform_get_drvdata, so drop this unused
> call.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
FWIW sanity checked it is indeed not used that I can see.

Reviewed-by: Jonathan Cameron <[email protected]>

> ---
> drivers/counter/microchip-tcb-capture.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index 0ab1b2716784..bb69f2e0ba93 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, priv);
> -
> match = of_match_node(atmel_tc_of_match, np->parent);
> tcb_config = match->data;
> if (!tcb_config) {


2021-12-29 06:44:38

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH v2 03/23] counter: microchip-tcb-capture: Drop unused platform_set_drvdata()

On Mon, Dec 27, 2021 at 10:45:06AM +0100, Uwe Kleine-König wrote:
> The driver doesn't ever use platform_get_drvdata, so drop this unused
> call.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Acked-by: William Breathitt Gray <[email protected]>

> ---
> drivers/counter/microchip-tcb-capture.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index 0ab1b2716784..bb69f2e0ba93 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, priv);
> -
> match = of_match_node(atmel_tc_of_match, np->parent);
> tcb_config = match->data;
> if (!tcb_config) {
> --
> 2.33.0
>

Attachments:
(No filename) (894.00 B)
 signature.asc (833.00 B)
 Download all attachments