2021-08-28 09:01:31

by Cai,Huoqing

Subject: [PATCH] pcmcia: Make use of the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()

Use the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() instead of
the verbose operators ".suspend_noirq /.resume_noirq/.freeze_noirq/
.thaw_noirq/.poweroff_noirq/.restore_noirq", because the
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a nice helper macro that could
be brought in to make code a little clearer, a little more concise.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/pcmcia/yenta_socket.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index 84bfc0e85d6b..e472da29d401 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -1342,12 +1342,7 @@ static int yenta_dev_resume_noirq(struct device *dev)
}

static const struct dev_pm_ops yenta_pm_ops = {
- .suspend_noirq = yenta_dev_suspend_noirq,
- .resume_noirq = yenta_dev_resume_noirq,
- .freeze_noirq = yenta_dev_suspend_noirq,
- .thaw_noirq = yenta_dev_resume_noirq,
- .poweroff_noirq = yenta_dev_suspend_noirq,
- .restore_noirq = yenta_dev_resume_noirq,
+ SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(yenta_dev_suspend_noirq, yenta_dev_resume_noirq)
};

#define YENTA_PM_OPS (&yenta_pm_ops)
--
2.25.1

2022-01-02 18:06:45

by Dominik Brodowski

Subject: Re: [PATCH] pcmcia: Make use of the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()

Am Sat, Aug 28, 2021 at 05:00:11PM +0800 schrieb Cai Huoqing:
> Use the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() instead of
> the verbose operators ".suspend_noirq /.resume_noirq/.freeze_noirq/
> .thaw_noirq/.poweroff_noirq/.restore_noirq", because the
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a nice helper macro that could
> be brought in to make code a little clearer, a little more concise.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Applied to pcmcia-next.

Thanks,
Dominik