2022-01-05 15:20:18

by Jiapeng Chong

Subject: [PATCH] crypto: qat - Unsigned comparison with less than zero

Fix coccicheck warning:

./drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING:
Unsigned expression compared with zero: ret < 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
index 6d10edc40aca..68d39c833332 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
@@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
static int get_service_enabled(struct adf_accel_dev *accel_dev)
{
char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
- u32 ret;
+ int ret;

ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
ADF_SERVICES_ENABLED, services);
--
2.20.1.7.g153144c

2022-01-05 15:26:42

by Cabiddu, Giovanni

Subject: Re: [PATCH] crypto: qat - Unsigned comparison with less than zero

On Wed, Jan 05, 2022 at 11:20:05PM +0800, Jiapeng Chong wrote:
> Fix coccicheck warning:
>
> ./drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c:67:5-8: WARNING:
> Unsigned expression compared with zero: ret < 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
There is already a patch under review that fixes this:
https://marc.info/?l=linux-crypto-vger&m=164138836020725&w=2

Thanks,

--
Giovanni