2022-01-21 13:57:13

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: i2c: imx: Make each example a separate entry

Each independent example should be a separate entry. This allows for
'interrupts' to have different cell sizes.

Signed-off-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
index c167958ae2a9..01720e338b4c 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
@@ -88,9 +88,7 @@ unevaluatedProperties: false
examples:
- |
#include <dt-bindings/clock/imx5-clock.h>
- #include <dt-bindings/clock/vf610-clock.h>
- #include <dt-bindings/gpio/gpio.h>
- #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>

i2c@83fc4000 {
compatible = "fsl,imx51-i2c", "fsl,imx21-i2c";
@@ -99,6 +97,9 @@ examples:
clocks = <&clks IMX5_CLK_I2C2_GATE>;
};

+ - |
+ #include <dt-bindings/clock/vf610-clock.h>
+
i2c@40066000 {
compatible = "fsl,vf610-i2c";
reg = <0x40066000 0x1000>;
--
2.32.0

2022-01-22 00:33:30

by Oleksij Rempel

Subject: Re: [PATCH] dt-bindings: i2c: imx: Make each example a separate entry

On Tue, Jan 18, 2022 at 07:52:53PM -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This allows for
> 'interrupts' to have different cell sizes.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Oleksij Rempel <[email protected]>

Thank you!

> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> index c167958ae2a9..01720e338b4c 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
> @@ -88,9 +88,7 @@ unevaluatedProperties: false
> examples:
> - |
> #include <dt-bindings/clock/imx5-clock.h>
> - #include <dt-bindings/clock/vf610-clock.h>
> - #include <dt-bindings/gpio/gpio.h>
> - #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
>
> i2c@83fc4000 {
> compatible = "fsl,imx51-i2c", "fsl,imx21-i2c";
> @@ -99,6 +97,9 @@ examples:
> clocks = <&clks IMX5_CLK_I2C2_GATE>;
> };
>
> + - |
> + #include <dt-bindings/clock/vf610-clock.h>
> +
> i2c@40066000 {
> compatible = "fsl,vf610-i2c";
> reg = <0x40066000 0x1000>;
> --
> 2.32.0
>
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-01-24 09:40:38

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: i2c: imx: Make each example a separate entry

On Tue, 18 Jan 2022 19:52:53 -0600, Rob Herring wrote:
> Each independent example should be a separate entry. This allows for
> 'interrupts' to have different cell sizes.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>

Applied, thanks!