This is supposed to fix "make dt_binding_check":
Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
camera@20: port:endpoint: Unevaluated properties are not allowed
('link-frequencies', 'data-lanes' were unexpected)
From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
revision history
----------------
v2: thank you, Laurent
* add unevaluatedProperties: false
v1:
https://lore.kernel.org/linux-media/[email protected]/
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 85a8877c2f38..5d0fc18a2ea2 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -49,7 +49,8 @@ properties:
description: Definition of the regulator used for the VDDD power supply.
port:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
properties:
endpoint:
--
2.30.2
link-frequencies is required but only mentioned in the example. Add
it to the description.
Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
Signed-off-by: Martin Kepplinger <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 5d0fc18a2ea2..1e2df8cf2937 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -69,8 +69,11 @@ properties:
- const: 1
- const: 2
+ link-frequencies: true
+
required:
- data-lanes
+ - link-frequencies
required:
- compatible
--
2.30.2
Hi Martin,
Thank you for the patch.
On Tue, Jan 11, 2022 at 02:39:36PM +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
Maybe s/is supposed to fix/fixes/ ? :-) No need to post a new version
just for that, I think it can be changed when applying the patch. Sakari
?
Reviewed-by: Laurent Pinchart <[email protected]>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
>
>
> revision history
> ----------------
> v2: thank you, Laurent
> * add unevaluatedProperties: false
> v1:
> https://lore.kernel.org/linux-media/[email protected]/
>
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 85a8877c2f38..5d0fc18a2ea2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -49,7 +49,8 @@ properties:
> description: Definition of the regulator used for the VDDD power supply.
>
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
>
> properties:
> endpoint:
--
Regards,
Laurent Pinchart
On Tue, 11 Jan 2022 14:39:36 +0100, Martin Kepplinger wrote:
> This is supposed to fix "make dt_binding_check":
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.example.dt.yaml:
> camera@20: port:endpoint: Unevaluated properties are not allowed
> ('link-frequencies', 'data-lanes' were unexpected)
> From schema: Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
>
>
> revision history
> ----------------
> v2: thank you, Laurent
> * add unevaluatedProperties: false
> v1:
> https://lore.kernel.org/linux-media/[email protected]/
>
>
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <[email protected]>
On Tue, 11 Jan 2022 14:39:37 +0100, Martin Kepplinger wrote:
> link-frequencies is required but only mentioned in the example. Add
> it to the description.
>
> Fixes: f3ce7200ca18 ("media: dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor")
> Signed-off-by: Martin Kepplinger <[email protected]>
> Reviewed-by: Laurent Pinchart <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Rob Herring <[email protected]>