2022-01-31 11:31:11

by Tommaso Merciai

Subject: [PATCH v3] usb: usb251xb: add boost-up property support

Add support for boost-up register of usb251xb hub.
boost-up property control USB electrical drive strength
This register can be set:

- Normal mode -> 0x00
- Low -> 0x01
- Medium -> 0x10
- High -> 0x11

(Normal Default)

References:
- http://www.mouser.com/catalog/specsheets/2514.pdf p29

Signed-off-by: Tommaso Merciai <[email protected]>
---
Changes since v1:
- Fix patch as suggested by RLeitner

Changes since v2:
- Fix commit body as suggested by Shtylyov
- Fix commit msg
- Fix patch as suggested by RLeitner and Shtylyov

drivers/usb/misc/usb251xb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 507deef1f709..04c4e3fed094 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -543,6 +543,9 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
if (of_property_read_u16_array(np, "language-id", &hub->lang_id, 1))
hub->lang_id = USB251XB_DEF_LANGUAGE_ID;

+ if (of_property_read_u8(np, "boost-up", &hub->boost_up))
+ hub->boost_up = USB251XB_DEF_BOOST_UP;
+
cproperty_char = of_get_property(np, "manufacturer", NULL);
strlcpy(str, cproperty_char ? : USB251XB_DEF_MANUFACTURER_STRING,
sizeof(str));
@@ -584,7 +587,6 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
* may be as soon as needed.
*/
hub->bat_charge_en = USB251XB_DEF_BATTERY_CHARGING_ENABLE;
- hub->boost_up = USB251XB_DEF_BOOST_UP;
hub->boost_57 = USB251XB_DEF_BOOST_57;
hub->boost_14 = USB251XB_DEF_BOOST_14;
hub->port_map12 = USB251XB_DEF_PORT_MAP_12;
--
2.25.1

2022-02-01 08:52:01

by Richard Leitner

Subject: Re: [PATCH v3] usb: usb251xb: add boost-up property support

LGTM. Please feel free to add

Reviewed-by: Richard Leitner <[email protected]>

On Fri, Jan 28, 2022 at 07:17:13PM +0100, Tommaso Merciai wrote:
> Add support for boost-up register of usb251xb hub.
> boost-up property control USB electrical drive strength
> This register can be set:
>
> - Normal mode -> 0x00
> - Low -> 0x01
> - Medium -> 0x10
> - High -> 0x11
>
> (Normal Default)
>
> References:
> - http://www.mouser.com/catalog/specsheets/2514.pdf p29
>
> Signed-off-by: Tommaso Merciai <[email protected]>
> ---
> Changes since v1:
> - Fix patch as suggested by RLeitner
>
> Changes since v2:
> - Fix commit body as suggested by Shtylyov
> - Fix commit msg
> - Fix patch as suggested by RLeitner and Shtylyov
>
> drivers/usb/misc/usb251xb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index 507deef1f709..04c4e3fed094 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -543,6 +543,9 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
> if (of_property_read_u16_array(np, "language-id", &hub->lang_id, 1))
> hub->lang_id = USB251XB_DEF_LANGUAGE_ID;
>
> + if (of_property_read_u8(np, "boost-up", &hub->boost_up))
> + hub->boost_up = USB251XB_DEF_BOOST_UP;
> +
> cproperty_char = of_get_property(np, "manufacturer", NULL);
> strlcpy(str, cproperty_char ? : USB251XB_DEF_MANUFACTURER_STRING,
> sizeof(str));
> @@ -584,7 +587,6 @@ static int usb251xb_get_ofdata(struct usb251xb *hub,
> * may be as soon as needed.
> */
> hub->bat_charge_en = USB251XB_DEF_BATTERY_CHARGING_ENABLE;
> - hub->boost_up = USB251XB_DEF_BOOST_UP;
> hub->boost_57 = USB251XB_DEF_BOOST_57;
> hub->boost_14 = USB251XB_DEF_BOOST_14;
> hub->port_map12 = USB251XB_DEF_PORT_MAP_12;
> --
> 2.25.1
>