2022-02-02 13:11:57

by Anshuman Khandual

Subject: [PATCH] perf: tools: Add missing branch_sample_type

This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.

Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: [email protected]
Cc: [email protected]
Suggested-by: James Clark <[email protected]>
Signed-off-by: Anshuman Khandual <[email protected]>
---
tools/perf/util/perf_event_attr_fprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
index 47b7531f51da..98af3fa4ea35 100644
--- a/tools/perf/util/perf_event_attr_fprintf.c
+++ b/tools/perf/util/perf_event_attr_fprintf.c
@@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
- bit_name(HW_INDEX),
+ bit_name(TYPE_SAVE), bit_name(HW_INDEX),
{ .name = NULL, }
};
#undef bit_name
--
2.20.1

2022-02-04 18:00:22

by Jiri Olsa

Subject: Re: [PATCH] perf: tools: Add missing branch_sample_type

On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> Cc: Mark Rutland <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Suggested-by: James Clark <[email protected]>
> Signed-off-by: Anshuman Khandual <[email protected]>

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka

> ---
> tools/perf/util/perf_event_attr_fprintf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> index 47b7531f51da..98af3fa4ea35 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
> bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
> bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
> bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> - bit_name(HW_INDEX),
> + bit_name(TYPE_SAVE), bit_name(HW_INDEX),
> { .name = NULL, }
> };
> #undef bit_name
> --
> 2.20.1
>

2022-02-07 16:43:51

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: tools: Add missing branch_sample_type

Em Wed, Feb 02, 2022 at 05:55:45PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 02, 2022 at 04:27:23PM +0530, Anshuman Khandual wrote:
> > This updates branch sample type with missing PERF_SAMPLE_BRANCH_TYPE_SAVE.
> >
> > Cc: Peter Zijlstra <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Cc: Arnaldo Carvalho de Melo <[email protected]>
> > Cc: Mark Rutland <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Suggested-by: James Clark <[email protected]>
> > Signed-off-by: Anshuman Khandual <[email protected]>
>
> Acked-by: Jiri Olsa <[email protected]>

Thanks, applied.

- Arnaldo


> thanks,
> jirka
>
> > ---
> > tools/perf/util/perf_event_attr_fprintf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> > index 47b7531f51da..98af3fa4ea35 100644
> > --- a/tools/perf/util/perf_event_attr_fprintf.c
> > +++ b/tools/perf/util/perf_event_attr_fprintf.c
> > @@ -52,7 +52,7 @@ static void __p_branch_sample_type(char *buf, size_t size, u64 value)
> > bit_name(ABORT_TX), bit_name(IN_TX), bit_name(NO_TX),
> > bit_name(COND), bit_name(CALL_STACK), bit_name(IND_JUMP),
> > bit_name(CALL), bit_name(NO_FLAGS), bit_name(NO_CYCLES),
> > - bit_name(HW_INDEX),
> > + bit_name(TYPE_SAVE), bit_name(HW_INDEX),
> > { .name = NULL, }
> > };
> > #undef bit_name
> > --
> > 2.20.1
> >

--

- Arnaldo