2022-02-09 10:39:50

by Corentin LABBE

[permalink] [raw]
Subject: Re: [PATCH v3] dt-bindings: timer: Convert faraday,fttmr010 to yaml

Le Wed, Feb 09, 2022 at 10:07:22AM +0100, Krzysztof Kozlowski a ?crit :
> On 09/02/2022 10:00, Corentin Labbe wrote:
> > Converts timer/faraday,fttmr010.txt to yaml.
>
> s/Converts/Convert/
>
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > Changes since v1:
> > - added moxart example
> > - relaxed some contraints as driver only support one clock and one
> > interrupt (as used by moxa,moxart-timer)
> > Changes since v2:
> > - increased max size of interrupts
> > - fixed all issues reported by Rob https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
> >
> > All aspeed-bmc-vegman*dts are expected to fail and will be fixed via:
> > https://patchwork.ozlabs.org/project/linux-aspeed/patch/[email protected]/
> >
>
> (...)
>
> > +
> > + syscon:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > +
> > +additionalProperties: true
> > +
> This should be false (and was false in your v1).
>

Oups, sorry
I forgot to remove it, it was my first try to fix vegman DT.
Anyway I also forgotten to remove some property in example which will be no longer in vegman.

I will send a V4
Thanks