Some Allwinner devices come with an Image Signal Processor (ISP) that
allows processing camera data to produce good-looking images,
especially from raw bayer representations.
The ISP does not have a dedicated capture path: it is fed directly by
one of the CSI controllers, which can be selected at run-time.
Represent this possibility as a graph connection between the CSI
controller and the ISP in the device-tree bindings.
Signed-off-by: Paul Kocialkowski <[email protected]>
---
.../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
index 3cc61866ea89..7952413f98d8 100644
--- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
+++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
@@ -83,6 +83,20 @@ properties:
additionalProperties: false
+ port@2:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ description: ISP output port
+
+ properties:
+ reg:
+ const: 2
+
+ endpoint:
+ $ref: video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ additionalProperties: false
+
anyOf:
- required:
- port@0
--
2.34.1
On Sat, Feb 05, 2022 at 07:54:25PM +0100, Paul Kocialkowski wrote:
> Some Allwinner devices come with an Image Signal Processor (ISP) that
> allows processing camera data to produce good-looking images,
> especially from raw bayer representations.
>
> The ISP does not have a dedicated capture path: it is fed directly by
> one of the CSI controllers, which can be selected at run-time.
>
> Represent this possibility as a graph connection between the CSI
> controller and the ISP in the device-tree bindings.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> .../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> index 3cc61866ea89..7952413f98d8 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> @@ -83,6 +83,20 @@ properties:
>
> additionalProperties: false
>
> + port@2:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + description: ISP output port
> +
> + properties:
> + reg:
> + const: 2
> +
> + endpoint:
> + $ref: video-interfaces.yaml#
> + unevaluatedProperties: false
This could be
$ref: video-interfaces.yaml#
remote-endpoint: true
additionalProperties: false
to reject other properties.
Reviewed-by: Laurent Pinchart <[email protected]>
> +
> + additionalProperties: false
> +
> anyOf:
> - required:
> - port@0
--
Regards,
Laurent Pinchart
On Mon, Feb 07, 2022 at 06:04:51PM +0200, Laurent Pinchart wrote:
> On Sat, Feb 05, 2022 at 07:54:25PM +0100, Paul Kocialkowski wrote:
> > Some Allwinner devices come with an Image Signal Processor (ISP) that
> > allows processing camera data to produce good-looking images,
> > especially from raw bayer representations.
> >
> > The ISP does not have a dedicated capture path: it is fed directly by
> > one of the CSI controllers, which can be selected at run-time.
> >
> > Represent this possibility as a graph connection between the CSI
> > controller and the ISP in the device-tree bindings.
> >
> > Signed-off-by: Paul Kocialkowski <[email protected]>
> > ---
> > .../bindings/media/allwinner,sun6i-a31-csi.yaml | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > index 3cc61866ea89..7952413f98d8 100644
> > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > @@ -83,6 +83,20 @@ properties:
> >
> > additionalProperties: false
> >
> > + port@2:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + description: ISP output port
> > +
> > + properties:
> > + reg:
> > + const: 2
> > +
> > + endpoint:
> > + $ref: video-interfaces.yaml#
> > + unevaluatedProperties: false
>
> This could be
>
> $ref: video-interfaces.yaml#
> remote-endpoint: true
> additionalProperties: false
>
> to reject other properties.
If that's what is desired, then video-interfaces.yaml shouldn't be
referenced and up above should be /properties/port.
Rob