2022-02-14 05:01:40

by Lu Baolu

Subject: [PATCH v3 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain

The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
field. Retrieve the value from the right place.

Signed-off-by: Lu Baolu <[email protected]>
Reviewed-by: Robin Murphy <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Christoph Hellwig <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index d0d52c1d4aee..992cc285f2fe 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -133,7 +133,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)
* or equal to the system's PAGE_SIZE, with a preference if
* both are equal.
*/
- pgsize_bitmap = tdev->iommu.domain->ops->pgsize_bitmap;
+ pgsize_bitmap = tdev->iommu.domain->pgsize_bitmap;
if (pgsize_bitmap & PAGE_SIZE) {
tdev->iommu.pgshift = PAGE_SHIFT;
} else {
--
2.25.1

2022-02-14 20:05:04

by Joerg Roedel

Subject: Re: [PATCH v3 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain

On Mon, Feb 14, 2022 at 09:55:34AM +0800, Lu Baolu wrote:
> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
> field. Retrieve the value from the right place.
>
> Signed-off-by: Lu Baolu <[email protected]>
> Reviewed-by: Robin Murphy <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]
> Reviewed-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Jason Gunthorpe <[email protected]>

Acked-by: Joerg Roedel <[email protected]>

I guess this is picked up by the DRM maintainers?

2022-02-15 04:32:11

by Lu Baolu

Subject: Re: [PATCH v3 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain

On 2/14/22 8:52 PM, Joerg Roedel wrote:
> On Mon, Feb 14, 2022 at 09:55:34AM +0800, Lu Baolu wrote:
>> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
>> field. Retrieve the value from the right place.
>>
>> Signed-off-by: Lu Baolu <[email protected]>
>> Reviewed-by: Robin Murphy <[email protected]>
>> Link: https://lore.kernel.org/r/[email protected]
>> Reviewed-by: Christoph Hellwig <[email protected]>
>> Reviewed-by: Jason Gunthorpe <[email protected]>
>
> Acked-by: Joerg Roedel <[email protected]>
>
> I guess this is picked up by the DRM maintainers?
>

I would like this patch to go through the iommu tree. This series could
not be compiled without this change.

Best regards,
baolu