2022-03-02 16:58:26

by Vinod Koul

Subject: Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property

On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
> Update description for audio CSR reset control property, which is
> required for latest chipsets to allow software enabling in CGCR HCLK register.

too many acronyms pls explain!

>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Co-developed-by: Venkata Prasad Potturu <[email protected]>
> Signed-off-by: Venkata Prasad Potturu <[email protected]>
> ---
> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> index b93a2b3..84c8f54 100644
> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
> @@ -150,6 +150,18 @@ board specific bus parameters.
> or applicable for the respective data port.
> More info in MIPI Alliance SoundWire 1.0 Specifications.
>
> +- reset:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: Should specify the SoundWire audio CSR reset controller interface,
> + which is required for SoundWire version 1.6.0 and above.
> +
> +- reset-names:
> + Usage: optional
> + Value type: <stringlist>
> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
> + controller interface.
> +

We should add these in example as well...

> Note:
> More Information on detail of encoding of these fields can be
> found in MIPI Alliance SoundWire 1.0 Specifications.
> --
> 2.7.4

--
~Vinod

2022-03-03 01:56:27

by Srinivasa Rao Mandadapu

Subject: Re: [PATCH v6 3/3] dt-bindings: soundwire: qcom: Add bindings for audio CSR reset control property

On 3/2/2022 9:18 PM, Vinod Koul wrote:
Thanks for your time Vinod!!!
> On 02-03-22, 18:13, Srinivasa Rao Mandadapu wrote:
>> Update description for audio CSR reset control property, which is
>> required for latest chipsets to allow software enabling in CGCR HCLK register.
> too many acronyms pls explain!
Okay. Will expand and re post the patch.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> Co-developed-by: Venkata Prasad Potturu <[email protected]>
>> Signed-off-by: Venkata Prasad Potturu <[email protected]>
>> ---
>> Documentation/devicetree/bindings/soundwire/qcom,sdw.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> index b93a2b3..84c8f54 100644
>> --- a/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> +++ b/Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>> @@ -150,6 +150,18 @@ board specific bus parameters.
>> or applicable for the respective data port.
>> More info in MIPI Alliance SoundWire 1.0 Specifications.
>>
>> +- reset:
>> + Usage: optional
>> + Value type: <prop-encoded-array>
>> + Definition: Should specify the SoundWire audio CSR reset controller interface,
>> + which is required for SoundWire version 1.6.0 and above.
>> +
>> +- reset-names:
>> + Usage: optional
>> + Value type: <stringlist>
>> + Definition: should be "swr_audio_cgcr" for SoundWire audio CSR reset
>> + controller interface.
>> +
> We should add these in example as well...
Okay. Will add in Example.
>
>> Note:
>> More Information on detail of encoding of these fields can be
>> found in MIPI Alliance SoundWire 1.0 Specifications.
>> --
>> 2.7.4