2022-02-25 10:19:06

by baihaowen

Subject: [PATCH] soc: qcom: qmi: Use min() instead of doing it manually

Fix following coccicheck warning:
drivers/soc/qcom/qmi_interface.c:773:12-13: WARNING opportunity for min()

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/soc/qcom/qmi_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/qmi_interface.c b/drivers/soc/qcom/qmi_interface.c
index c8c4c73..3337a70 100644
--- a/drivers/soc/qcom/qmi_interface.c
+++ b/drivers/soc/qcom/qmi_interface.c
@@ -770,7 +770,7 @@ static ssize_t qmi_send_message(struct qmi_handle *qmi,

kfree(msg);

- return ret < 0 ? ret : 0;
+ return min(ret, 0);
}

/**
--
2.7.4

2022-03-01 10:40:09

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: qmi: Use min() instead of doing it manually

On Mon 28 Feb 19:36 CST 2022, lotte bai wrote:

> Fix following coccicheck warning:
> drivers/soc/qcom/qmi_interface.c:773:12-13: WARNING opportunity for min()
>

Thanks for the patch Haowen.

> Signed-off-by: Haowen Bai <[email protected]>
> ---
> drivers/soc/qcom/qmi_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qmi_interface.c
> b/drivers/soc/qcom/qmi_interface.c
> index c8c4c73..3337a70 100644
> --- a/drivers/soc/qcom/qmi_interface.c
> +++ b/drivers/soc/qcom/qmi_interface.c
> @@ -770,7 +770,7 @@ static ssize_t qmi_send_message(struct qmi_handle *qmi,
>
> kfree(msg);
>
> - return ret < 0 ? ret : 0;
> + return min(ret, 0);

The code isn't trying to say "return the minimum of ret and 0", it says
"if ret is negative return that, otherwise return 0".

Mathematically this happens to be the same, but for me as reader of the
code they have different meaning.

Regards,
Bjorn