2022-02-16 06:37:02

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] cpuset: Fix kernel-doc

Fix the following W=1 kernel warnings:

kernel/cgroup/cpuset.c:3718: warning: expecting prototype for
cpuset_memory_pressure_bump(). Prototype was for
__cpuset_memory_pressure_bump() instead.

kernel/cgroup/cpuset.c:3568: warning: expecting prototype for
cpuset_node_allowed(). Prototype was for __cpuset_node_allowed()
instead.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
kernel/cgroup/cpuset.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 97c53f3cc917..5de18448016c 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3524,8 +3524,8 @@ static struct cpuset *nearest_hardwall_ancestor(struct cpuset *cs)
return cs;
}

-/**
- * cpuset_node_allowed - Can we allocate on a memory node?
+/*
+ * __cpuset_node_allowed - Can we allocate on a memory node?
* @node: is this an allowed node?
* @gfp_mask: memory allocation flags
*
@@ -3696,8 +3696,8 @@ void cpuset_print_current_mems_allowed(void)

int cpuset_memory_pressure_enabled __read_mostly;

-/**
- * cpuset_memory_pressure_bump - keep stats of per-cpuset reclaims.
+/*
+ * __cpuset_memory_pressure_bump - keep stats of per-cpuset reclaims.
*
* Keep a running average of the rate of synchronous (direct)
* page reclaim efforts initiated by tasks in each cpuset.
@@ -3712,7 +3712,7 @@ int cpuset_memory_pressure_enabled __read_mostly;
* "memory_pressure". Value displayed is an integer
* representing the recent rate of entry into the synchronous
* (direct) page reclaim by any task attached to the cpuset.
- **/
+ */

void __cpuset_memory_pressure_bump(void)
{
--
2.20.1.7.g153144c


2022-02-23 02:38:56

by Tejun Heo

[permalink] [raw]
Subject: Re: [PATCH] cpuset: Fix kernel-doc

On Wed, Feb 16, 2022 at 11:17:53AM +0800, Jiapeng Chong wrote:
> Fix the following W=1 kernel warnings:
>
> kernel/cgroup/cpuset.c:3718: warning: expecting prototype for
> cpuset_memory_pressure_bump(). Prototype was for
> __cpuset_memory_pressure_bump() instead.
>
> kernel/cgroup/cpuset.c:3568: warning: expecting prototype for
> cpuset_node_allowed(). Prototype was for __cpuset_node_allowed()
> instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Applied to cgroup/for-5.17-fixes.

Thanks.

--
tejun