From: Bjorn Helgaas <[email protected]>
This is based on Hans' extensive debugging and patch at
https://lore.kernel.org/r/[email protected]
and applies on 7e57714cd0ad ("Linux 5.17-rc6").
This is basically the same idea (applying the 4dc2287c1805 workaround only
when an E820 region *partially* overlaps a host bridge window), but I think
it's a little simpler.
This also adds a little dmesg output when clipping, which should make
future debugging easier.
I bcc'd several folks who didn't have public email addresses in the RedHat
bugzilla or Launchpad. If you review or test this, I'd be happy to
acknowledge that.
Bjorn Helgaas (3):
x86/PCI: Eliminate remove_e820_regions() common subexpressions
x86/PCI: Log host bridge window clipping for E820 regions
x86/PCI: Preserve host bridge windows completely covered by E820
arch/x86/include/asm/e820/api.h | 5 +++++
arch/x86/kernel/resource.c | 34 ++++++++++++++++++++++++++-------
arch/x86/pci/acpi.c | 5 +++++
3 files changed, 37 insertions(+), 7 deletions(-)
--
2.25.1
Hi Bjorn,
On 3/4/22 04:51, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> This is based on Hans' extensive debugging and patch at
> https://lore.kernel.org/r/[email protected]
> and applies on 7e57714cd0ad ("Linux 5.17-rc6").
>
> This is basically the same idea (applying the 4dc2287c1805 workaround only
> when an E820 region *partially* overlaps a host bridge window), but I think
> it's a little simpler.
>
> This also adds a little dmesg output when clipping, which should make
> future debugging easier.
>
> I bcc'd several folks who didn't have public email addresses in the RedHat
> bugzilla or Launchpad. If you review or test this, I'd be happy to
> acknowledge that.
>
> Bjorn Helgaas (3):
> x86/PCI: Eliminate remove_e820_regions() common subexpressions
> x86/PCI: Log host bridge window clipping for E820 regions
> x86/PCI: Preserve host bridge windows completely covered by E820
Thanks, I agree that this is better then my fix I also like the logging
added to 2/3 which lets us know if the commit 4dc2287c1805 workaround
is active.
I have one small remark on 3/3. Regardless of that getting addressed
the entire series is:
Reviewed-by: Hans de Goede <[email protected]>
I've done a Fedora test kernel build of 5.16.12 with these 3 patches
added and asked the reporters of:
https://bugzilla.redhat.com/show_bug.cgi?id=1868899
(ideapad touchpad bug)
and:
https://bugzilla.redhat.com/show_bug.cgi?id=2029207
(Lenovo x1 carbon gen 2 regression with my bios-data based fix_
to test the rpms and to collect dmesg. On the X1C2 this should show
the new logging from 2/3 "in action" and on the ideapad the touchpad
should still work...
Regards,
Hans
Hi,
On Fri, Mar 04, 2022 at 03:15:16PM +0100, Hans de Goede wrote:
> Hi Bjorn,
>
> On 3/4/22 04:51, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > This is based on Hans' extensive debugging and patch at
> > https://lore.kernel.org/r/[email protected]
> > and applies on 7e57714cd0ad ("Linux 5.17-rc6").
> >
> > This is basically the same idea (applying the 4dc2287c1805 workaround only
> > when an E820 region *partially* overlaps a host bridge window), but I think
> > it's a little simpler.
> >
> > This also adds a little dmesg output when clipping, which should make
> > future debugging easier.
> >
> > I bcc'd several folks who didn't have public email addresses in the RedHat
> > bugzilla or Launchpad. If you review or test this, I'd be happy to
> > acknowledge that.
> >
> > Bjorn Helgaas (3):
> > x86/PCI: Eliminate remove_e820_regions() common subexpressions
> > x86/PCI: Log host bridge window clipping for E820 regions
> > x86/PCI: Preserve host bridge windows completely covered by E820
>
> Thanks, I agree that this is better then my fix I also like the logging
> added to 2/3 which lets us know if the commit 4dc2287c1805 workaround
> is active.
>
> I have one small remark on 3/3. Regardless of that getting addressed
> the entire series is:
>
> Reviewed-by: Hans de Goede <[email protected]>
Looks good to me too :)
Reviewed-by: Mika Westerberg <[email protected]>