2022-03-07 18:22:51

by Naresh Kamboju

Subject: [next] mips: madvise.c:55:7: error: 'MADV_DONTNEED_LOCKED' undeclared

Following build regressions errors/warnings noticed on mips architecture on
linux next-20220307 build.

make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/build ARCH=mips
CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc'
'HOSTCC=sccache gcc'

mm/madvise.c: In function 'madvise_need_mmap_write':
mm/madvise.c:55:7: error: 'MADV_DONTNEED_LOCKED' undeclared (first use
in this function); did you mean 'MADV_DONTNEED'?
55 | case MADV_DONTNEED_LOCKED:
| ^~~~~~~~~~~~~~~~~~~~
| MADV_DONTNEED
mm/madvise.c:55:7: note: each undeclared identifier is reported only
once for each function it appears in
mm/madvise.c: In function 'madvise_dontneed_free_valid_vma':
mm/madvise.c:789:19: error: 'MADV_DONTNEED_LOCKED' undeclared (first
use in this function); did you mean 'MADV_DONTNEED'?
789 | if (behavior != MADV_DONTNEED_LOCKED)
| ^~~~~~~~~~~~~~~~~~~~
| MADV_DONTNEED
mm/madvise.c: In function 'madvise_dontneed_free':
mm/madvise.c:859:47: error: 'MADV_DONTNEED_LOCKED' undeclared (first
use in this function); did you mean 'MADV_DONTNEED'?
859 | if (behavior == MADV_DONTNEED || behavior == MADV_DONTNEED_LOCKED)
| ^~~~~~~~~~~~~~~~~~~~
| MADV_DONTNEED
mm/madvise.c: In function 'madvise_vma_behavior':
mm/madvise.c:998:7: error: 'MADV_DONTNEED_LOCKED' undeclared (first
use in this function); did you mean 'MADV_DONTNEED'?
998 | case MADV_DONTNEED_LOCKED:
| ^~~~~~~~~~~~~~~~~~~~
| MADV_DONTNEED
mm/madvise.c: In function 'madvise_behavior_valid':
mm/madvise.c:1129:7: error: 'MADV_DONTNEED_LOCKED' undeclared (first
use in this function); did you mean 'MADV_DONTNEED'?
1129 | case MADV_DONTNEED_LOCKED:
| ^~~~~~~~~~~~~~~~~~~~
| MADV_DONTNEED
mm/madvise.c: In function 'madvise_dontneed_free':
mm/madvise.c:865:1: error: control reaches end of non-void function
[-Werror=return-type]
865 | }
| ^
cc1: some warnings being treated as errors


Reported-by: Linux Kernel Functional Testing <[email protected]>

steps to reproduce:
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake

tuxmake --runtime podman --target-arch mips --toolchain gcc-10
--kconfig rt305x_defconfig


Build log [1].

--
Linaro LKFT
https://lkft.linaro.org

[1] https://builds.tuxbuild.com/2639g1Qugd13m3pgWwKp4I34Cb1/

2022-03-07 23:49:20

by Johannes Weiner

Subject: Re: [next] mips: madvise.c:55:7: error: 'MADV_DONTNEED_LOCKED' undeclared

On Mon, Mar 07, 2022 at 09:45:38PM +0530, Naresh Kamboju wrote:
> Following build regressions errors/warnings noticed on mips architecture on
> linux next-20220307 build.
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/build ARCH=mips
> CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc'
> 'HOSTCC=sccache gcc'
>
> mm/madvise.c: In function 'madvise_need_mmap_write':
> mm/madvise.c:55:7: error: 'MADV_DONTNEED_LOCKED' undeclared (first use
> in this function); did you mean 'MADV_DONTNEED'?
> 55 | case MADV_DONTNEED_LOCKED:

Thanks for the report, I sent a fix in reply to Stephen:

https://lore.kernel.org/lkml/[email protected]/T/#m58a9804edb680303b7351fb7cf6d9c93096ccaad