2022-03-25 19:06:12

by [email protected]

Subject: [RFC PATCH v2 1/7] libperf tests: Fix typo in the error message

This patch corrects a typo in the error message.

Signed-off-by: Shunsuke Nakamura <[email protected]>
---
tools/lib/perf/tests/test-evlist.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
index fa854c83b7e7..ed616fc19b4f 100644
--- a/tools/lib/perf/tests/test-evlist.c
+++ b/tools/lib/perf/tests/test-evlist.c
@@ -69,7 +69,7 @@ static int test_stat_cpu(void)
perf_evlist__set_maps(evlist, cpus, NULL);

err = perf_evlist__open(evlist);
- __T("failed to open evsel", err == 0);
+ __T("failed to open evlist", err == 0);

perf_evlist__for_each_evsel(evlist, evsel) {
cpus = perf_evsel__cpus(evsel);
@@ -130,7 +130,7 @@ static int test_stat_thread(void)
perf_evlist__set_maps(evlist, NULL, threads);

err = perf_evlist__open(evlist);
- __T("failed to open evsel", err == 0);
+ __T("failed to open evlist", err == 0);

perf_evlist__for_each_evsel(evlist, evsel) {
perf_evsel__read(evsel, 0, 0, &counts);
@@ -187,7 +187,7 @@ static int test_stat_thread_enable(void)
perf_evlist__set_maps(evlist, NULL, threads);

err = perf_evlist__open(evlist);
- __T("failed to open evsel", err == 0);
+ __T("failed to open evlist", err == 0);

perf_evlist__for_each_evsel(evlist, evsel) {
perf_evsel__read(evsel, 0, 0, &counts);
@@ -507,7 +507,7 @@ static int test_stat_multiplexing(void)
perf_evlist__set_maps(evlist, NULL, threads);

err = perf_evlist__open(evlist);
- __T("failed to open evsel", err == 0);
+ __T("failed to open evlist", err == 0);

perf_evlist__enable(evlist);

--
2.25.1

2022-03-25 20:37:53

by Arnaldo Carvalho de Melo

Subject: Re: [RFC PATCH v2 1/7] libperf tests: Fix typo in the error message

Em Fri, Mar 25, 2022 at 01:38:23PM +0900, Shunsuke Nakamura escreveu:
> This patch corrects a typo in the error message.

Thanks, applied. Will wait for review for the other patches in this
series.

- Arnaldo


> Signed-off-by: Shunsuke Nakamura <[email protected]>
> ---
> tools/lib/perf/tests/test-evlist.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/lib/perf/tests/test-evlist.c b/tools/lib/perf/tests/test-evlist.c
> index fa854c83b7e7..ed616fc19b4f 100644
> --- a/tools/lib/perf/tests/test-evlist.c
> +++ b/tools/lib/perf/tests/test-evlist.c
> @@ -69,7 +69,7 @@ static int test_stat_cpu(void)
> perf_evlist__set_maps(evlist, cpus, NULL);
>
> err = perf_evlist__open(evlist);
> - __T("failed to open evsel", err == 0);
> + __T("failed to open evlist", err == 0);
>
> perf_evlist__for_each_evsel(evlist, evsel) {
> cpus = perf_evsel__cpus(evsel);
> @@ -130,7 +130,7 @@ static int test_stat_thread(void)
> perf_evlist__set_maps(evlist, NULL, threads);
>
> err = perf_evlist__open(evlist);
> - __T("failed to open evsel", err == 0);
> + __T("failed to open evlist", err == 0);
>
> perf_evlist__for_each_evsel(evlist, evsel) {
> perf_evsel__read(evsel, 0, 0, &counts);
> @@ -187,7 +187,7 @@ static int test_stat_thread_enable(void)
> perf_evlist__set_maps(evlist, NULL, threads);
>
> err = perf_evlist__open(evlist);
> - __T("failed to open evsel", err == 0);
> + __T("failed to open evlist", err == 0);
>
> perf_evlist__for_each_evsel(evlist, evsel) {
> perf_evsel__read(evsel, 0, 0, &counts);
> @@ -507,7 +507,7 @@ static int test_stat_multiplexing(void)
> perf_evlist__set_maps(evlist, NULL, threads);
>
> err = perf_evlist__open(evlist);
> - __T("failed to open evsel", err == 0);
> + __T("failed to open evlist", err == 0);
>
> perf_evlist__enable(evlist);
>
> --
> 2.25.1

--

- Arnaldo