2022-03-17 13:05:09

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
struct group_desc to be defined in pinctrl/core.h.

Add the missing select line to CONFIG_PINCTRL_WPCM450.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
drivers/pinctrl/nuvoton/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
index 6a3c6f2a73f2d..b48d32912bef1 100644
--- a/drivers/pinctrl/nuvoton/Kconfig
+++ b/drivers/pinctrl/nuvoton/Kconfig
@@ -6,6 +6,7 @@ config PINCTRL_WPCM450
select PINMUX
select PINCONF
select GENERIC_PINCONF
+ select GENERIC_PINCTRL_GROUPS
select GPIOLIB
select GPIO_GENERIC
select GPIOLIB_IRQCHIP
--
2.35.1


2022-03-17 15:47:46

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

On Thu, Mar 17, 2022 at 12:44:12PM +0100, Jonathan Neuschäfer wrote:
> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

Ah well, I forgot

Fixes: a1d1e0e3d80a8 ("pinctrl: nuvoton: Add driver for WPCM450")

which would be appropriate here.


> ---
> drivers/pinctrl/nuvoton/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 6a3c6f2a73f2d..b48d32912bef1 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -6,6 +6,7 @@ config PINCTRL_WPCM450
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> + select GENERIC_PINCTRL_GROUPS
> select GPIOLIB
> select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> --
> 2.35.1
>

Attachments:
(No filename) (1.01 kB)
 signature.asc (849.00 B)
 Download all attachments

2022-03-25 13:27:13

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS

On Thu, Mar 17, 2022 at 12:44 PM Jonathan Neuschäfer
<[email protected]> wrote:

> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

Patch applied with the Fixes: tag!

Thanks!
Linus Walleij