2022-03-04 10:57:49

by Suzuki K Poulose

[permalink] [raw]
Subject: [GIT PULL] coresight changes for v5.18

Hi Greg

Please find the pull request for coresight subsystem for v5.18.

Suzuki

The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:

Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18

for you to fetch changes up to b54f53bc11a584713f79a704c70c488489f524b8:

coresight: Drop unused 'none' enum value for each component (2022-02-28 09:51:40 -0700)

----------------------------------------------------------------
coresight: changes for v5.18

The coresight update for v5.18 includes
- TRBE erratum workarounds for Arm Cortex-A510
- Fixes for leaking root namespace PIDs into non-root namespace
trace sessions
- Miscellaneous fixes and cleanups

Signed-off-by: Suzuki K Poulose <[email protected]>

----------------------------------------------------------------
Anshuman Khandual (4):
coresight: trbe: Work around the ignored system register writes
coresight: trbe: Work around the invalid prohibited states
coresight: trbe: Work around the trace data corruption
coresight: Drop unused 'none' enum value for each component

James Clark (2):
coresight: Fix TRCCONFIGR.QE sysfs interface
coresight: no-op refactor to make INSTP0 check more idiomatic

Leo Yan (4):
coresight: etm4x: Add lock for reading virtual context ID comparator
coresight: etm4x: Don't use virtual contextID for non-root PID namespace
coresight: etm4x: Don't trace PID for non-root PID namespace
coresight: etm3x: Don't trace PID for non-root PID namespace

Miaoqian Lin (1):
coresight: syscfg: Fix memleak on registration failure in cscfg_create_device

Rafael J. Wysocki (1):
hwtracing: coresight: Replace acpi_bus_get_device()

Sudeep Holla (1):
coresight: trbe: Move check for kernel page table isolation from EL0 to probe

arch/arm64/Kconfig | 6 +-
drivers/hwtracing/coresight/coresight-core.c | 3 -
drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +
drivers/hwtracing/coresight/coresight-etm4x-core.c | 12 +-
.../hwtracing/coresight/coresight-etm4x-sysfs.c | 38 ++++++-
drivers/hwtracing/coresight/coresight-platform.c | 8 +-
drivers/hwtracing/coresight/coresight-syscfg.c | 2 +-
drivers/hwtracing/coresight/coresight-trbe.c | 125 +++++++++++++++------
drivers/hwtracing/coresight/coresight-trbe.h | 8 --
include/linux/coresight.h | 5 -
10 files changed, 149 insertions(+), 62 deletions(-)


2022-03-11 00:58:14

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [GIT PULL] coresight changes for v5.18

On Thu, Mar 03, 2022 at 11:03:01PM +0000, Suzuki K Poulose wrote:
> Hi Greg
>
> Please find the pull request for coresight subsystem for v5.18.
>
> Suzuki
>
> The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:
>
> Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18
>
> for you to fetch changes up to b54f53bc11a584713f79a704c70c488489f524b8:
>
> coresight: Drop unused 'none' enum value for each component (2022-02-28 09:51:40 -0700)

I have the following errors when pulling this tree and having the
scripts check the commits:

Commit 5340bf5df9d2 ("coresight: syscfg: Fix memleak on registration failure in cscfg_create_device")
committer Signed-off-by missing
author email: [email protected]
committer email: [email protected]
Signed-off-by: Miaoqian Lin <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>

Commit 91a2f2941df2 ("coresight: Fix TRCCONFIGR.QE sysfs interface")
committer Signed-off-by missing
author email: [email protected]
committer email: [email protected]
Signed-off-by: James Clark <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>

Commit 7f4cd3375906 ("coresight: trbe: Work around the trace data corruption")
committer Signed-off-by missing
author email: [email protected]
committer email: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>

Commit 0ecf2c747437 ("coresight: trbe: Work around the invalid prohibited states")
committer Signed-off-by missing
author email: [email protected]
committer email: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>

Commit 8b6927d0adad ("coresight: trbe: Work around the ignored system register writes")
committer Signed-off-by missing
author email: [email protected]
committer email: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
Signed-off-by: Mathieu Poirier <[email protected]>


What went wrong???

linux-next didn't complain about this already?

greg k-h

2022-03-11 11:48:39

by Mathieu Poirier

[permalink] [raw]
Subject: Re: [GIT PULL] coresight changes for v5.18

On Thu, 10 Mar 2022 at 14:44, Greg KH <[email protected]> wrote:
>
> On Thu, Mar 03, 2022 at 11:03:01PM +0000, Suzuki K Poulose wrote:
> > Hi Greg
> >
> > Please find the pull request for coresight subsystem for v5.18.
> >
> > Suzuki
> >
> > The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:
> >
> > Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18
> >
> > for you to fetch changes up to b54f53bc11a584713f79a704c70c488489f524b8:
> >
> > coresight: Drop unused 'none' enum value for each component (2022-02-28 09:51:40 -0700)
>
> I have the following errors when pulling this tree and having the
> scripts check the commits:
>
> Commit 5340bf5df9d2 ("coresight: syscfg: Fix memleak on registration failure in cscfg_create_device")
> committer Signed-off-by missing
> author email: [email protected]
> committer email: [email protected]
> Signed-off-by: Miaoqian Lin <[email protected]>
> Signed-off-by: Mathieu Poirier <[email protected]>
>
> Commit 91a2f2941df2 ("coresight: Fix TRCCONFIGR.QE sysfs interface")
> committer Signed-off-by missing
> author email: [email protected]
> committer email: [email protected]
> Signed-off-by: James Clark <[email protected]>
> Signed-off-by: Mathieu Poirier <[email protected]>
>
> Commit 7f4cd3375906 ("coresight: trbe: Work around the trace data corruption")
> committer Signed-off-by missing
> author email: [email protected]
> committer email: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>
> Signed-off-by: Mathieu Poirier <[email protected]>
>
> Commit 0ecf2c747437 ("coresight: trbe: Work around the invalid prohibited states")
> committer Signed-off-by missing
> author email: [email protected]
> committer email: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>
> Signed-off-by: Mathieu Poirier <[email protected]>
>
> Commit 8b6927d0adad ("coresight: trbe: Work around the ignored system register writes")
> committer Signed-off-by missing
> author email: [email protected]
> committer email: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>
> Signed-off-by: Mathieu Poirier <[email protected]>
>
>
> What went wrong???
>

(Sigh)

I know what happened. The tree was rebased from -rc1 to -rc3 to pick
up a dependency with the aarch64 tree that was needed for a patch. In
doing so the original committer information was overwritten, which is
what the script is complaining about.

We will send you another pull request.

> linux-next didn't complain about this already?
>

It did not.

Thanks for the patience,
Mathieu

2022-03-11 21:54:24

by Suzuki K Poulose

[permalink] [raw]
Subject: [GIT PULL] [v2] coresight: Changes for v5.18

Greg,

Please find coresight updates for v5.18 below. This is an updated pull
request which fixes the missing s-o-b tags for the committer.

Changes since previous request:
- Fix missing S-o-b tags for committer
- Added a new tag coresight-next-v5.18-v2

Thanks
Suzuki


The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:

Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18-v2

for you to fetch changes up to 286f950545e0d9c8aa802cbfc9676860bbc49179:

coresight: Drop unused 'none' enum value for each component (2022-03-11 10:07:57 +0000)

----------------------------------------------------------------
coresight: changes for v5.18

The coresight update for v5.18 includes
- TRBE erratum workarounds for Arm Cortex-A510
- Fixes for leaking root namespace PIDs into non-root namespace
trace sessions
- Miscellaneous fixes and cleanups

Updated tag to reflect missing committer s-o-b tags.

Signed-off-by: Suzuki K Poulose <[email protected]>

----------------------------------------------------------------
Anshuman Khandual (4):
coresight: trbe: Work around the ignored system register writes
coresight: trbe: Work around the invalid prohibited states
coresight: trbe: Work around the trace data corruption
coresight: Drop unused 'none' enum value for each component

James Clark (2):
coresight: Fix TRCCONFIGR.QE sysfs interface
coresight: no-op refactor to make INSTP0 check more idiomatic

Leo Yan (4):
coresight: etm4x: Add lock for reading virtual context ID comparator
coresight: etm4x: Don't use virtual contextID for non-root PID namespace
coresight: etm4x: Don't trace PID for non-root PID namespace
coresight: etm3x: Don't trace PID for non-root PID namespace

Miaoqian Lin (1):
coresight: syscfg: Fix memleak on registration failure in cscfg_create_device

Rafael J. Wysocki (1):
hwtracing: coresight: Replace acpi_bus_get_device()

Sudeep Holla (1):
coresight: trbe: Move check for kernel page table isolation from EL0 to probe

arch/arm64/Kconfig | 6 +-
drivers/hwtracing/coresight/coresight-core.c | 3 -
drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +
drivers/hwtracing/coresight/coresight-etm4x-core.c | 12 +-
.../hwtracing/coresight/coresight-etm4x-sysfs.c | 38 ++++++-
drivers/hwtracing/coresight/coresight-platform.c | 8 +-
drivers/hwtracing/coresight/coresight-syscfg.c | 2 +-
drivers/hwtracing/coresight/coresight-trbe.c | 125 +++++++++++++++------
drivers/hwtracing/coresight/coresight-trbe.h | 8 --
include/linux/coresight.h | 5 -
10 files changed, 149 insertions(+), 62 deletions(-)

2022-03-11 22:35:59

by Suzuki K Poulose

[permalink] [raw]
Subject: Re: [GIT PULL] coresight changes for v5.18

On 11/03/2022 00:09, Mathieu Poirier wrote:
> On Thu, 10 Mar 2022 at 14:44, Greg KH <[email protected]> wrote:
>>
>> On Thu, Mar 03, 2022 at 11:03:01PM +0000, Suzuki K Poulose wrote:
>>> Hi Greg
>>>
>>> Please find the pull request for coresight subsystem for v5.18.
>>>
>>> Suzuki
>>>
>>> The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:
>>>
>>> Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)
>>>
>>> are available in the Git repository at:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18
>>>
>>> for you to fetch changes up to b54f53bc11a584713f79a704c70c488489f524b8:
>>>
>>> coresight: Drop unused 'none' enum value for each component (2022-02-28 09:51:40 -0700)
>>
>> I have the following errors when pulling this tree and having the
>> scripts check the commits:
>>
>> Commit 5340bf5df9d2 ("coresight: syscfg: Fix memleak on registration failure in cscfg_create_device")
>> committer Signed-off-by missing
>> author email: [email protected]
>> committer email: [email protected]
>> Signed-off-by: Miaoqian Lin <[email protected]>
>> Signed-off-by: Mathieu Poirier <[email protected]>
>>
>> Commit 91a2f2941df2 ("coresight: Fix TRCCONFIGR.QE sysfs interface")
>> committer Signed-off-by missing
>> author email: [email protected]
>> committer email: [email protected]
>> Signed-off-by: James Clark <[email protected]>
>> Signed-off-by: Mathieu Poirier <[email protected]>
>>
>> Commit 7f4cd3375906 ("coresight: trbe: Work around the trace data corruption")
>> committer Signed-off-by missing
>> author email: [email protected]
>> committer email: [email protected]
>> Signed-off-by: Anshuman Khandual <[email protected]>
>> Signed-off-by: Mathieu Poirier <[email protected]>
>>
>> Commit 0ecf2c747437 ("coresight: trbe: Work around the invalid prohibited states")
>> committer Signed-off-by missing
>> author email: [email protected]
>> committer email: [email protected]
>> Signed-off-by: Anshuman Khandual <[email protected]>
>> Signed-off-by: Mathieu Poirier <[email protected]>
>>
>> Commit 8b6927d0adad ("coresight: trbe: Work around the ignored system register writes")
>> committer Signed-off-by missing
>> author email: [email protected]
>> committer email: [email protected]
>> Signed-off-by: Anshuman Khandual <[email protected]>
>> Signed-off-by: Mathieu Poirier <[email protected]>
>>
>>
>> What went wrong???
>>
>
> (Sigh)
>
> I know what happened. The tree was rebased from -rc1 to -rc3 to pick
> up a dependency with the aarch64 tree that was needed for a patch. In
> doing so the original committer information was overwritten, which is
> what the script is complaining about.
>
> We will send you another pull request.

Apologies. I have fixed them now and will send you the updated request.

Thanks for your patience.

Suzuki

2022-03-18 16:03:56

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [GIT PULL] [v2] coresight: Changes for v5.18

On Fri, Mar 11, 2022 at 10:45:57AM +0000, Suzuki K Poulose wrote:
> Greg,
>
> Please find coresight updates for v5.18 below. This is an updated pull
> request which fixes the missing s-o-b tags for the committer.
>
> Changes since previous request:
> - Fix missing S-o-b tags for committer
> - Added a new tag coresight-next-v5.18-v2
>
> Thanks
> Suzuki
>
>
> The following changes since commit dfd42facf1e4ada021b939b4e19c935dcdd55566:
>
> Linux 5.17-rc3 (2022-02-06 12:20:50 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git tags/coresight-next-v5.18-v2

Pulled and pushed out, thanks.

greg k-h