2022-03-21 11:04:29

by Stafford Horne

[permalink] [raw]
Subject: Re: [PATCH V2 5/5] openrisc: Move to ticket-spinlock

On Sun, Mar 20, 2022 at 12:36:31PM +0900, Stafford Horne wrote:
> On Sun, Mar 20, 2022, 12:05 PM Guo Ren <[email protected]> wrote:
>
> > Hi openrisc guys,
> >
> > > kernel/signal.c:2625:49: sparse: expected struct sighand_struct
> > *sighand
> > > kernel/signal.c:2625:49: sparse: got struct sighand_struct
> > [noderef] __rcu *sighand
> >
> > Some warning here, Is that all right? I don't think it is because of
> > changing arch_spinlock_t from struct qspinlock to atomic_t.
> >
>
> I haven't built or tested this series yet. But this doesn't look like a
> new problem. It looks like this patch series may have introduced a new
> instance of the existing issue.
>
> I have some patches to clean up sparse warnings and I've seen this pattern
> before but haven't spent the time to clean it up. This is a good
> opportunity to do that now. Let me have a look in the next few days.

Hello Guo Ren,

I was able to build the patch series for OpenRISC, but after applying the
openrisc SMP kernel build no longer can boot. It doesn't boot on single core
system or multi-core systems. I don't get any console output to help with
debugging it.

It may take be a bit longer to debug this.

-Stafford