2022-03-21 09:57:18

by Konrad Dybcio

Subject: [PATCH 01/15] arm64: dts: qcom: msm8994: Fix sleep clock name

The sleep clock name expected by GCC is actually "sleep" and not
"sleep_clk". Fix the clock-names value for it to make sure it is
provided.

Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8994.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qcom/msm8994.dtsi
index 215f56daa26c..c7bb8235a169 100644
--- a/arch/arm64/boot/dts/qcom/msm8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi
@@ -714,7 +714,7 @@ gcc: clock-controller@fc400000 {
#power-domain-cells = <1>;
reg = <0xfc400000 0x2000>;

- clock-names = "xo", "sleep_clk";
+ clock-names = "xo", "sleep";
clocks = <&xo_board>, <&sleep_clk>;
};

--
2.35.1

2022-03-24 17:55:00

by Petr Vorel

Subject: Re: [PATCH 01/15] arm64: dts: qcom: msm8994: Fix sleep clock name

Hi Konrad, all,

> The sleep clock name expected by GCC is actually "sleep" and not
> "sleep_clk". Fix the clock-names value for it to make sure it is
> provided.

> Fixes: 9204da57cd65 ("arm64: dts: qcom: msm8994: Provide missing "xo_board" and "sleep_clk" to GCC")
Thanks for fixing it, now I see it in
Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml

Reviewed-by: Petr Vorel <[email protected]>

I also tested it with "clk: qcom: gcc-msm8994: Fix gpll4 width" [1]
and "[PATCH v5 1/1] arm64: dts: qcom: msm8994-huawei-angler: Add sdhc1 definition" [2]
and it works as expected.

Reviewed-by: Petr Vorel <[email protected]>

Kind regards,
Petr

[1] https://lore.kernel.org/linux-arm-msm/[email protected]/
[2] https://lore.kernel.org/linux-arm-msm/[email protected]/