2022-04-07 20:49:29

by Stephen Kitt

[permalink] [raw]
Subject: [PATCH v2 10/10] clk: renesas-pcie: use simple i2c probe function

The i2c probe function here doesn't use the id information provided in
its second argument, so the single-parameter i2c probe function
("probe_new") can be used instead.

This avoids scanning the identifier tables during probes.

Signed-off-by: Stephen Kitt <[email protected]>
---
drivers/clk/clk-renesas-pcie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pcie.c
index 59d9cf0053eb..4f5df1fc74b4 100644
--- a/drivers/clk/clk-renesas-pcie.c
+++ b/drivers/clk/clk-renesas-pcie.c
@@ -213,7 +213,7 @@ rs9_of_clk_get(struct of_phandle_args *clkspec, void *data)
return rs9->clk_dif[idx];
}

-static int rs9_probe(struct i2c_client *client, const struct i2c_device_id *id)
+static int rs9_probe(struct i2c_client *client)
{
unsigned char name[5] = "DIF0";
struct rs9_driver_data *rs9;
@@ -312,7 +312,7 @@ static struct i2c_driver rs9_driver = {
.pm = &rs9_pm_ops,
.of_match_table = clk_rs9_of_match,
},
- .probe = rs9_probe,
+ .probe_new = rs9_probe,
.id_table = rs9_id,
};
module_i2c_driver(rs9_driver);
--
2.27.0


2022-04-07 21:28:40

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2 01/10] clk: cdce706: use simple i2c probe function

On Thu, Apr 07, 2022 at 05:18:22PM +0200, Stephen Kitt wrote:
> The i2c probe function here doesn't use the id information provided in
> its second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> This avoids scanning the identifier tables during probes.
>
> Signed-off-by: Stephen Kitt <[email protected]>

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (424.00 B)
signature.asc (849.00 B)
Download all attachments

2022-04-07 21:29:06

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2 10/10] clk: renesas-pcie: use simple i2c probe function

On Thu, Apr 07, 2022 at 05:18:31PM +0200, Stephen Kitt wrote:
> The i2c probe function here doesn't use the id information provided in
> its second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> This avoids scanning the identifier tables during probes.
>
> Signed-off-by: Stephen Kitt <[email protected]>

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (424.00 B)
signature.asc (849.00 B)
Download all attachments

2022-04-23 03:15:19

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v2 10/10] clk: renesas-pcie: use simple i2c probe function

Quoting Stephen Kitt (2022-04-07 08:18:31)
> The i2c probe function here doesn't use the id information provided in
> its second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> This avoids scanning the identifier tables during probes.
>
> Signed-off-by: Stephen Kitt <[email protected]>
> ---

Applied to clk-next