2022-03-28 21:17:44

by Masahiro Yamada

Subject: [PATCH] media: media.h: remove unneeded <stdint.h> inclusion

Commit b3b7a9f138b7 ("[media] media-device: Use u64 ints for pointers")
added this #include <stdint.h>, presumably in order to use uintptr_t.

Now that it is gone, we can compile this for userspace without <stdint.h>.

Signed-off-by: Masahiro Yamada <[email protected]>
---

include/uapi/linux/media.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index 200fa8462b90..5754dce922a7 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux/media.h
@@ -20,9 +20,6 @@
#ifndef __LINUX_MEDIA_H
#define __LINUX_MEDIA_H

-#ifndef __KERNEL__
-#include <stdint.h>
-#endif
#include <linux/ioctl.h>
#include <linux/types.h>

--
2.32.0

2022-03-28 21:37:29

by Laurent Pinchart

Subject: Re: [PATCH] media: media.h: remove unneeded <stdint.h> inclusion

Hi Yamada-san,

Thank you for the patch.

On Tue, Mar 29, 2022 at 01:01:53AM +0900, Masahiro Yamada wrote:
> Commit b3b7a9f138b7 ("[media] media-device: Use u64 ints for pointers")
> added this #include <stdint.h>, presumably in order to use uintptr_t.
>
> Now that it is gone, we can compile this for userspace without <stdint.h>.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>
> include/uapi/linux/media.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 200fa8462b90..5754dce922a7 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -20,9 +20,6 @@
> #ifndef __LINUX_MEDIA_H
> #define __LINUX_MEDIA_H
>
> -#ifndef __KERNEL__
> -#include <stdint.h>
> -#endif
> #include <linux/ioctl.h>
> #include <linux/types.h>
>

--
Regards,

Laurent Pinchart