2022-03-31 04:17:51

by Chris Down

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: Add printk indexing maintainers on mention of printk_index

This will primarily catch new and changed printk_index_subsys_emit
calls, but it's also worth catching changes to other printk indexing
infrastructure outside of kernel/printk/index.c.

This avoids churn due to missing ccs when adding new printk indexes, as
was the case recently for the first round of the XFS printk indexing
patches.

Signed-off-by: Chris Down <[email protected]>
Cc: Petr Mladek <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index e3b11033e628..45121b9e943d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15404,6 +15404,7 @@ PRINTK INDEXING
R: Chris Down <[email protected]>
S: Maintained
F: kernel/printk/index.c
+K: printk_index

PROC FILESYSTEM
L: [email protected]
--
2.35.1


2022-04-01 17:57:41

by Chris Down

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add printk indexing maintainers on mention of printk_index

Petr Mladek writes:
>On Wed 2022-03-30 15:32:20, Chris Down wrote:
>> This will primarily catch new and changed printk_index_subsys_emit
>> calls, but it's also worth catching changes to other printk indexing
>> infrastructure outside of kernel/printk/index.c.
>>
>> This avoids churn due to missing ccs when adding new printk indexes, as
>> was the case recently for the first round of the XFS printk indexing
>> patches.
>>
>> Signed-off-by: Chris Down <[email protected]>
>> Cc: Petr Mladek <[email protected]>
>
>Nice trick. I was not aware of that K: entries.
>
>I have pushed the patch into printk/linux.git, branch for-5.19.
>
>We missed the direct 5.18 train. I will add the commit into
>a printk pull request for 5.18-rcX if there is any. But I think
>that it is not worth creating a pull request just with this change.
>
>I am going to make sure that you are added into CC in the meantime.
>I hope that they will add me at least ;-)

Sounds good, thank you! :-)

2022-04-02 12:53:40

by Petr Mladek

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add printk indexing maintainers on mention of printk_index

On Wed 2022-03-30 15:32:20, Chris Down wrote:
> This will primarily catch new and changed printk_index_subsys_emit
> calls, but it's also worth catching changes to other printk indexing
> infrastructure outside of kernel/printk/index.c.
>
> This avoids churn due to missing ccs when adding new printk indexes, as
> was the case recently for the first round of the XFS printk indexing
> patches.
>
> Signed-off-by: Chris Down <[email protected]>
> Cc: Petr Mladek <[email protected]>

Nice trick. I was not aware of that K: entries.

I have pushed the patch into printk/linux.git, branch for-5.19.

We missed the direct 5.18 train. I will add the commit into
a printk pull request for 5.18-rcX if there is any. But I think
that it is not worth creating a pull request just with this change.

I am going to make sure that you are added into CC in the meantime.
I hope that they will add me at least ;-)

Best Regards,
Petr