2022-03-31 04:08:13

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: manual merge of the device-mapper tree with the block tree

Hi all,

Today's linux-next merge of the device-mapper tree got a conflict in:

include/linux/bio.h

between commit:

57c47b42f454 ("block: turn bio_kmalloc into a simple kmalloc wrapper")

from the block tree and commit:

135eaaabd22a ("block: allow using the per-cpu bio cache from bio_alloc_bioset")

from the device-mapper tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

--
Cheers,
Stephen Rothwell

diff --cc include/linux/bio.h
index ab77473c855b,8c42b67c41c7..000000000000
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@@ -405,9 -408,7 +405,7 @@@ extern int bioset_init_from_src(struct
struct bio *bio_alloc_bioset(struct block_device *bdev, unsigned short nr_vecs,
unsigned int opf, gfp_t gfp_mask,
struct bio_set *bs);
- struct bio *bio_alloc_kiocb(struct kiocb *kiocb, struct block_device *bdev,
- unsigned short nr_vecs, unsigned int opf, struct bio_set *bs);
-struct bio *bio_kmalloc(gfp_t gfp_mask, unsigned short nr_iovecs);
+struct bio *bio_kmalloc(unsigned short nr_vecs, gfp_t gfp_mask);
extern void bio_put(struct bio *);

struct bio *bio_alloc_clone(struct block_device *bdev, struct bio *bio_src,


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-04-02 15:04:24

by Christoph Hellwig

[permalink] [raw]
Subject: Re: linux-next: manual merge of the device-mapper tree with the block tree

On Thu, Mar 31, 2022 at 09:44:25AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the device-mapper tree got a conflict in:
>
> include/linux/bio.h
>
> between commit:
>
> 57c47b42f454 ("block: turn bio_kmalloc into a simple kmalloc wrapper")
>
> from the block tree and commit:
>
> 135eaaabd22a ("block: allow using the per-cpu bio cache from bio_alloc_bioset")

Isn't this something Jens already had queued up in the block tree?

2022-04-03 14:10:41

by Mike Snitzer

[permalink] [raw]
Subject: Re: linux-next: manual merge of the device-mapper tree with the block tree

On Fri, Apr 01 2022 at 1:20P -0400,
Christoph Hellwig <[email protected]> wrote:

> On Thu, Mar 31, 2022 at 09:44:25AM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next merge of the device-mapper tree got a conflict in:
> >
> > include/linux/bio.h
> >
> > between commit:
> >
> > 57c47b42f454 ("block: turn bio_kmalloc into a simple kmalloc wrapper")
> >
> > from the block tree and commit:
> >
> > 135eaaabd22a ("block: allow using the per-cpu bio cache from bio_alloc_bioset")
>
> Isn't this something Jens already had queued up in the block tree?
>

Yes, but Jens hasn't staged 5.19 commits taken early in linux-next
yet. So I just left the changes in linux-dm.git's for-next to get
coverage in the interim.

Mike