Hi,
On 4/1/22 22:33, Anisse Astier wrote:
> Hi Sasha,
>
> Le Fri, Apr 01, 2022 at 10:23:08AM -0400, Sasha Levin a écrit :
>> From: Anisse Astier <[email protected]>
>>
>> [ Upstream commit 0b464ca3e0dd3cec65f28bc6d396d82f19080f69 ]
>>
>> Panel is 800x1280, but mounted on a laptop form factor, sideways.
>>
>> Signed-off-by: Anisse Astier <[email protected]>
>> Reviewed-by: Hans de Goede <[email protected]>
>> Signed-off-by: Jani Nikula <[email protected]>
>> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
>> Signed-off-by: Sasha Levin <[email protected]>
>
> I don't think this patch will be very useful, because it won't fix the
> device's display orientation without the previous patch it came with,
> titled "drm/i915/opregion: add support for mailbox #5 EDID"
> (e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be
> added
Well actually it will already put e.g. the text console the right way up
since efifb also uses this quirks and gives a hint to fbcon to rotate
the text. So it is not entirely useless.
And since all quirks added to drivers/gpu/drm/drm_panel_orientation_quirks.c
typically get backported having this one in place now will avoid conflicts
with future backports.
That combined with not really seeing a downside to already having
this in place even without the i915 support being sorted out makes
me lean more towards the direction of believing that having this
in 5.17 is fine...
Regards,
Hans
Le Sat, Apr 02, 2022 at 11:14:58AM +0200, Hans de Goede a ?crit :
> Hi,
>
> On 4/1/22 22:33, Anisse Astier wrote:
> > Hi Sasha,
> >
> > Le Fri, Apr 01, 2022 at 10:23:08AM -0400, Sasha Levin a ?crit :
> >> From: Anisse Astier <[email protected]>
> >>
> >> [ Upstream commit 0b464ca3e0dd3cec65f28bc6d396d82f19080f69 ]
> >>
> >> Panel is 800x1280, but mounted on a laptop form factor, sideways.
> >>
> >> Signed-off-by: Anisse Astier <[email protected]>
> >> Reviewed-by: Hans de Goede <[email protected]>
> >> Signed-off-by: Jani Nikula <[email protected]>
> >> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
> >> Signed-off-by: Sasha Levin <[email protected]>
> >
> > I don't think this patch will be very useful, because it won't fix the
> > device's display orientation without the previous patch it came with,
> > titled "drm/i915/opregion: add support for mailbox #5 EDID"
> > (e35d8762b04f89f9f5a188d0c440d3a2c1d010ed); while I'd like both to be
> > added
>
> Well actually it will already put e.g. the text console the right way up
> since efifb also uses this quirks and gives a hint to fbcon to rotate
> the text. So it is not entirely useless.
>
> And since all quirks added to drivers/gpu/drm/drm_panel_orientation_quirks.c
> typically get backported having this one in place now will avoid conflicts
> with future backports.
>
> That combined with not really seeing a downside to already having
> this in place even without the i915 support being sorted out makes
> me lean more towards the direction of believing that having this
> in 5.17 is fine...
>
Good points; lets's keep it in the stable queues.
Thanks,
Anisse