2022-02-25 07:55:45

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: defconfig: Enable Qualcomm GPI DMA Driver

On 24-02-22, 23:58, Bjorn Andersson wrote:
> On Thu 24 Feb 22:40 CST 2022, Vinod Koul wrote:
>
> > Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
> > like Geni I2C and SPI.
> >
> > Enable this dma driver
> >
> > Signed-off-by: Vinod Koul <[email protected]>
> > ---
> >
> > Changes in v2:
> > - As dicussed with Bjorn GPI DMA is used by Serial engines SPI/I2C so we
> > can make this a module rather than inbuilt
> >
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 30516dc0b70e..d73913f082d7 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
> > CONFIG_TEGRA20_APB_DMA=y
> > CONFIG_TEGRA210_ADMA=m
> > CONFIG_QCOM_BAM_DMA=y
> > +CONFIG_QCOM_GPI_DMA=y
>
> Would you like me to change this to =m as I apply the patch, just to
> make it match changelog? ;)

:(

Crap, looks like i forgot to add and did the amend, would be great if
you can, or I can send a v3...

--
~Vinod


2022-04-13 06:00:52

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: defconfig: Enable Qualcomm GPI DMA Driver

On Fri 25 Feb 00:10 CST 2022, Vinod Koul wrote:

> On 24-02-22, 23:58, Bjorn Andersson wrote:
> > On Thu 24 Feb 22:40 CST 2022, Vinod Koul wrote:
> >
> > > Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
> > > like Geni I2C and SPI.
> > >
> > > Enable this dma driver
> > >
> > > Signed-off-by: Vinod Koul <[email protected]>
> > > ---
> > >
> > > Changes in v2:
> > > - As dicussed with Bjorn GPI DMA is used by Serial engines SPI/I2C so we
> > > can make this a module rather than inbuilt
> > >
> > > arch/arm64/configs/defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index 30516dc0b70e..d73913f082d7 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
> > > CONFIG_TEGRA20_APB_DMA=y
> > > CONFIG_TEGRA210_ADMA=m
> > > CONFIG_QCOM_BAM_DMA=y
> > > +CONFIG_QCOM_GPI_DMA=y
> >
> > Would you like me to change this to =m as I apply the patch, just to
> > make it match changelog? ;)
>
> :(
>
> Crap, looks like i forgot to add and did the amend, would be great if
> you can, or I can send a v3...

I concluded that you didn't send v3, so I fixed this and applied it.

Thanks,
Bjorn

>
> --
> ~Vinod

2022-04-13 06:09:23

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: defconfig: Enable Qualcomm GPI DMA Driver

On 12-04-22, 21:21, Bjorn Andersson wrote:
> On Fri 25 Feb 00:10 CST 2022, Vinod Koul wrote:
>
> > On 24-02-22, 23:58, Bjorn Andersson wrote:
> > > On Thu 24 Feb 22:40 CST 2022, Vinod Koul wrote:
> > >
> > > > Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
> > > > like Geni I2C and SPI.
> > > >
> > > > Enable this dma driver
> > > >
> > > > Signed-off-by: Vinod Koul <[email protected]>
> > > > ---
> > > >
> > > > Changes in v2:
> > > > - As dicussed with Bjorn GPI DMA is used by Serial engines SPI/I2C so we
> > > > can make this a module rather than inbuilt
> > > >
> > > > arch/arm64/configs/defconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > index 30516dc0b70e..d73913f082d7 100644
> > > > --- a/arch/arm64/configs/defconfig
> > > > +++ b/arch/arm64/configs/defconfig
> > > > @@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
> > > > CONFIG_TEGRA20_APB_DMA=y
> > > > CONFIG_TEGRA210_ADMA=m
> > > > CONFIG_QCOM_BAM_DMA=y
> > > > +CONFIG_QCOM_GPI_DMA=y
> > >
> > > Would you like me to change this to =m as I apply the patch, just to
> > > make it match changelog? ;)
> >
> > :(
> >
> > Crap, looks like i forgot to add and did the amend, would be great if
> > you can, or I can send a v3...
>
> I concluded that you didn't send v3, so I fixed this and applied it.

Thanks! much appreciated... I have the v3 but looks like never sent it
:-(

--
~Vinod