Add Heiko to CC.
On 04/08/22 at 05:06pm, Baoquan He wrote:
> Copy the description of v3 cover letter from Willy:
> ===
> For some reason several people have been sending bad patches to fix
> compiler warnings in vmcore recently. Here's how it should be done.
> Compile-tested only on x86. As noted in the first patch, s390 should
> take this conversion a bit further, but I'm not inclined to do that
> work myself.
Forgot adding Heiko to CC again.
Hi Heiko,
Andrew worried you may miss the note, "As noted in the first patch,
s390 should take this conversion a bit further, but I'm not inclined
to do that work myself." written in cover letter from willy.
I told him you had already known this in v1 discussion. So add you in CC
list as Andrew required. Adding words to explain, just in case confusion.
>
> V4:
> [PATCH v4 0/3] Convert vmcore to use an iov_iter
> https://lore.kernel.org/all/[email protected]/T/#u
>
> v3:
> [PATCH v3 0/3] Convert vmcore to use an iov_iter
> https://lore.kernel.org/all/[email protected]/T/#u
>
>
> Changelog:
> ===
> v5 RESEND:
> - Add my own Signed-off-by, no code or log change related in this round.
>
> v5:
> - Rebased on Linus's latest master branch.
> - Merge the patch 4 of v4 into patch 2.
> v4:
> - Append one patch to replace the open code with iov_iter_count().
> This is suggested by Al.
> - Fix a indentation error by replacing space with tab in
> arch/sh/kernel/crash_dump.c of patch 1 reported by checkpatch. The
> rest of patch 1~3 are untouched.
> - Add Christopy's Reviewed-by and my Acked-by for patch 1~3.
> v3:
> - Send the correct patches this time
> v2:
> - Removed unnecessary kernel-doc
> - Included uio.h to fix compilation problems
> - Made read_from_oldmem_iter static to avoid compile warnings during the
> conversion
> - Use iov_iter_truncate() (Christoph)
>
>
> Matthew Wilcox (Oracle) (3):
> vmcore: Convert copy_oldmem_page() to take an iov_iter
> vmcore: Convert __read_vmcore to use an iov_iter
> vmcore: Convert read_from_oldmem() to take an iov_iter
>
> arch/arm/kernel/crash_dump.c | 27 +------
> arch/arm64/kernel/crash_dump.c | 29 +------
> arch/ia64/kernel/crash_dump.c | 32 +-------
> arch/mips/kernel/crash_dump.c | 27 +------
> arch/powerpc/kernel/crash_dump.c | 35 ++-------
> arch/riscv/kernel/crash_dump.c | 26 +------
> arch/s390/kernel/crash_dump.c | 13 ++--
> arch/sh/kernel/crash_dump.c | 29 ++-----
> arch/x86/kernel/crash_dump_32.c | 29 +------
> arch/x86/kernel/crash_dump_64.c | 48 ++++--------
> fs/proc/vmcore.c | 130 +++++++++++++------------------
> include/linux/crash_dump.h | 19 ++---
> 12 files changed, 123 insertions(+), 321 deletions(-)
>
> --
> 2.34.1
>
On Fri, Apr 08, 2022 at 05:24:28PM +0800, Baoquan He wrote:
> Add Heiko to CC.
>
> On 04/08/22 at 05:06pm, Baoquan He wrote:
> > Copy the description of v3 cover letter from Willy:
> > ===
> > For some reason several people have been sending bad patches to fix
> > compiler warnings in vmcore recently. Here's how it should be done.
> > Compile-tested only on x86. As noted in the first patch, s390 should
> > take this conversion a bit further, but I'm not inclined to do that
> > work myself.
>
> Forgot adding Heiko to CC again.
>
> Hi Heiko,
>
> Andrew worried you may miss the note, "As noted in the first patch,
> s390 should take this conversion a bit further, but I'm not inclined
> to do that work myself." written in cover letter from willy.
>
> I told him you had already known this in v1 discussion. So add you in CC
> list as Andrew required. Adding words to explain, just in case confusion.
Thanks for letting me know again. I'm still aware of this, but would
appreciate if I could be added to cc in the first patch of this
series, so I get notified when Andrew sends this Linus.
Thanks a lot!
On 04/11/22 at 10:59am, Heiko Carstens wrote:
> On Fri, Apr 08, 2022 at 05:24:28PM +0800, Baoquan He wrote:
> > Add Heiko to CC.
> >
> > On 04/08/22 at 05:06pm, Baoquan He wrote:
> > > Copy the description of v3 cover letter from Willy:
> > > ===
> > > For some reason several people have been sending bad patches to fix
> > > compiler warnings in vmcore recently. Here's how it should be done.
> > > Compile-tested only on x86. As noted in the first patch, s390 should
> > > take this conversion a bit further, but I'm not inclined to do that
> > > work myself.
> >
> > Forgot adding Heiko to CC again.
> >
> > Hi Heiko,
> >
> > Andrew worried you may miss the note, "As noted in the first patch,
> > s390 should take this conversion a bit further, but I'm not inclined
> > to do that work myself." written in cover letter from willy.
> >
> > I told him you had already known this in v1 discussion. So add you in CC
> > list as Andrew required. Adding words to explain, just in case confusion.
>
> Thanks for letting me know again. I'm still aware of this, but would
> appreciate if I could be added to cc in the first patch of this
> series, so I get notified when Andrew sends this Linus.
Right, it's my neglect. I should CC all involved during the discussion.
By the way, could both of you, Heiko, Christoph, help check this
patchset and offer your ack again if it's OK to you? I removed
Christoph's Reviewed-by because there's some change as per Al's
comment, and replace my own 'Acked-by' with 'Signed-off-by' according to
our posting rule.