On Tue, Mar 15, 2022 at 11:25:43PM +0100, Jonathan Neuschäfer wrote:
> On Wed, Mar 16, 2022 at 12:18:55AM +0200, Laurent Pinchart wrote:
> > Hi Jonathan,
> >
> > Thank you for the patch.
> >
> > On Tue, Mar 15, 2022 at 11:10:06PM +0100, Jonathan Neuschäfer wrote:
> > > As discussed with other developers, the linux-uvc-devel mailing list is
> > > not very useful anymore, and it's better to send people to the general
> > > linux-media mailing list.
> > >
> > > Replace/remove the old mailing list address in uvcvideo.rst and
> > > MAINTAINERS.
> > >
> > > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > > ---
> > >
> > > v2:
> > > - Changed mailing list to [email protected] instead
> > >
> > > v1:
> > > - https://lore.kernel.org/lkml/[email protected]/
> > > ---
> > > Documentation/userspace-api/media/drivers/uvcvideo.rst | 2 +-
> > > MAINTAINERS | 1 -
> >
> > This looks good, but I think we should also add the following:
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 5f394d4efc21..6c6a82af07ce 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2443,7 +2443,7 @@ static int uvc_probe(struct usb_interface *intf,
> > "Forcing device quirks to 0x%x by module parameter for testing purpose.\n",
> > dev->quirks);
> > dev_info(&dev->udev->dev,
> > - "Please report required quirks to the linux-uvc-devel mailing list.\n");
> > + "Please report required quirks to the linux-media mailing list.\n");
> > }
> >
> > if (dev->info->uvc_version) {
> >
> > If you're fine with that change, there's no need to resubmit, I can
> > handle this locally.
> >
> > Reviewed-by: Laurent Pinchart <[email protected]>
>
> Ah, just before I saw your reply, I noticed this instance too, and sent
> a separate patch for it.
I'd say great minds think alike if it wasn't presumptuous :-)
> I'll leave it up to you to handle it as you wish, I'm fine with it
> either way.
I'll squash the two patches as they're closely related.
--
Regards,
Laurent Pinchart
On Wed, Mar 16, 2022 at 12:40:12AM +0200, Laurent Pinchart wrote:
> On Tue, Mar 15, 2022 at 11:25:43PM +0100, Jonathan Neuschäfer wrote:
> > On Wed, Mar 16, 2022 at 12:18:55AM +0200, Laurent Pinchart wrote:
> > > Hi Jonathan,
> > >
> > > Thank you for the patch.
> > >
> > > On Tue, Mar 15, 2022 at 11:10:06PM +0100, Jonathan Neuschäfer wrote:
> > > > As discussed with other developers, the linux-uvc-devel mailing list is
> > > > not very useful anymore, and it's better to send people to the general
> > > > linux-media mailing list.
> > > >
> > > > Replace/remove the old mailing list address in uvcvideo.rst and
> > > > MAINTAINERS.
> > > >
> > > > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > > > ---
> > > >
> > > > v2:
> > > > - Changed mailing list to [email protected] instead
> > > >
> > > > v1:
> > > > - https://lore.kernel.org/lkml/[email protected]/
> > > > ---
> > > > Documentation/userspace-api/media/drivers/uvcvideo.rst | 2 +-
> > > > MAINTAINERS | 1 -
> > >
> > > This looks good, but I think we should also add the following:
> > >
> > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > > index 5f394d4efc21..6c6a82af07ce 100644
> > > --- a/drivers/media/usb/uvc/uvc_driver.c
> > > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > > @@ -2443,7 +2443,7 @@ static int uvc_probe(struct usb_interface *intf,
> > > "Forcing device quirks to 0x%x by module parameter for testing purpose.\n",
> > > dev->quirks);
> > > dev_info(&dev->udev->dev,
> > > - "Please report required quirks to the linux-uvc-devel mailing list.\n");
> > > + "Please report required quirks to the linux-media mailing list.\n");
> > > }
> > >
> > > if (dev->info->uvc_version) {
> > >
> > > If you're fine with that change, there's no need to resubmit, I can
> > > handle this locally.
> > >
> > > Reviewed-by: Laurent Pinchart <[email protected]>
> >
> > Ah, just before I saw your reply, I noticed this instance too, and sent
> > a separate patch for it.
>
> I'd say great minds think alike if it wasn't presumptuous :-)
>
> > I'll leave it up to you to handle it as you wish, I'm fine with it
> > either way.
>
> I'll squash the two patches as they're closely related.
Ping — I don't see this patch in linux-next. Is there something I can do
to help?
Jonathan
Hi Jonathan,
On Sat, Apr 16, 2022 at 05:31:54PM +0200, Jonathan Neuschäfer wrote:
> On Wed, Mar 16, 2022 at 12:40:12AM +0200, Laurent Pinchart wrote:
> > On Tue, Mar 15, 2022 at 11:25:43PM +0100, Jonathan Neuschäfer wrote:
> > > On Wed, Mar 16, 2022 at 12:18:55AM +0200, Laurent Pinchart wrote:
> > > > On Tue, Mar 15, 2022 at 11:10:06PM +0100, Jonathan Neuschäfer wrote:
> > > > > As discussed with other developers, the linux-uvc-devel mailing list is
> > > > > not very useful anymore, and it's better to send people to the general
> > > > > linux-media mailing list.
> > > > >
> > > > > Replace/remove the old mailing list address in uvcvideo.rst and
> > > > > MAINTAINERS.
> > > > >
> > > > > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > > > > ---
> > > > >
> > > > > v2:
> > > > > - Changed mailing list to [email protected] instead
> > > > >
> > > > > v1:
> > > > > - https://lore.kernel.org/lkml/[email protected]/
> > > > > ---
> > > > > Documentation/userspace-api/media/drivers/uvcvideo.rst | 2 +-
> > > > > MAINTAINERS | 1 -
> > > >
> > > > This looks good, but I think we should also add the following:
> > > >
> > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > > > index 5f394d4efc21..6c6a82af07ce 100644
> > > > --- a/drivers/media/usb/uvc/uvc_driver.c
> > > > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > > > @@ -2443,7 +2443,7 @@ static int uvc_probe(struct usb_interface *intf,
> > > > "Forcing device quirks to 0x%x by module parameter for testing purpose.\n",
> > > > dev->quirks);
> > > > dev_info(&dev->udev->dev,
> > > > - "Please report required quirks to the linux-uvc-devel mailing list.\n");
> > > > + "Please report required quirks to the linux-media mailing list.\n");
> > > > }
> > > >
> > > > if (dev->info->uvc_version) {
> > > >
> > > > If you're fine with that change, there's no need to resubmit, I can
> > > > handle this locally.
> > > >
> > > > Reviewed-by: Laurent Pinchart <[email protected]>
> > >
> > > Ah, just before I saw your reply, I noticed this instance too, and sent
> > > a separate patch for it.
> >
> > I'd say great minds think alike if it wasn't presumptuous :-)
> >
> > > I'll leave it up to you to handle it as you wish, I'm fine with it
> > > either way.
> >
> > I'll squash the two patches as they're closely related.
>
> Ping — I don't see this patch in linux-next. Is there something I can do
> to help?
I've just sent a pull request, the patch should make it to v5.19.
--
Regards,
Laurent Pinchart
On Mon, Apr 25, 2022 at 01:45:15AM +0300, Laurent Pinchart wrote:
> On Sat, Apr 16, 2022 at 05:31:54PM +0200, Jonathan Neuschäfer wrote:
[...]
> > Ping — I don't see this patch in linux-next. Is there something I can do
> > to help?
>
> I've just sent a pull request, the patch should make it to v5.19.
Great, thanks.
Jonathan